Closed Bug 1071275 Opened 5 years ago Closed 5 years ago

[meta] Enable Silk on Other platforms

Categories

(Firefox OS Graveyard :: Performance, defect, P2)

ARM
All
defect

Tracking

(firefox40 fixed)

RESOLVED FIXED
2.2 S11 (1may)
Tracking Status
firefox40 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

()

Details

(Whiteboard: [games:p2][platform-rel-Games])

Attachments

(1 file)

Once we get silk working on b2g, let's align the refresh driver / compositor / input across the other platforms.
Blocks: 1080869
Depends on: 552020
Depends on: 1127151
Duplicate of this bug: 689418
Depends on: 1128165
Assignee: nobody → mchang
Status: NEW → ASSIGNED
Depends on: 1129686
Depends on: 1130136
Depends on: 1133526
Depends on: 1133527
Try looks good on OS X + Windows with all of Silk enabled - https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa339e4699fd
Depends on: 1128690
Depends on: 1135136
Is there a bug filed for graphical corruption/artifacts after enabling vsync?
(In reply to Johannes Pfrang [:johnp] from comment #4)
> Is there a bug filed for graphical corruption/artifacts after enabling vsync?

Not at the moment, but you can file one as a dependent of this bug. What are you seeing?

You can also always disable it by setting these prefs to false on b2g:

gfx.vsync.hw-vsync.enabled
gfx.vsync.compositor
gfx.touch.resample
Depends on: 1137905
Blocks: 1138627
Depends on: 1139090
Depends on: 1140260
Depends on: 1140723
Depends on: 1144317
Depends on: 1144321
Depends on: 1144451
Depends on: 1146942
Depends on: 1149391
Depends on: 1150727
Depends on: 1151487
Depends on: 1151488
Depends on: 1151489
Once bug 1151488 lands, silk will be on everywhere. Hardware vsync on b2g kit-kat, Windows w/ DWM, and OS X. Software vsync everywhere else. Consolidate all the preferences into one place.
Attachment #8590884 - Flags: review?(bugmail.mozilla)
Blocks: 1133528
Comment on attachment 8590884 [details] [diff] [review]
Consoildate silk preferences

Review of attachment 8590884 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +4666,5 @@
>  #endif
>  
>  // Use vsync aligned rendering. b2g prefs are in b2g.js.
>  // Hardware vsync supported on windows, os x, and b2g.
>  // Linux and fennec will use software vsync.

I think just remove this entire comment block except for the first sentence. The rest of it may easily go out of date since people fiddling in other parts of the code may not update this. (The bits about b2g are already wrong/incomplete)
Attachment #8590884 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/1023edc0a85e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
Depends on: 1210261
Whiteboard: [games:p2] → [games:p2][platform-rel-Games]
You need to log in before you can comment on or make changes to this bug.