1071275 - [meta] Enable Silk on Other platforms

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Performance, defect, P2)

Description

[Mason Chang [Inactive] [:mchang]]

Once we get silk working on b2g, let's align the refresh driver / compositor / input across the other platforms.

Comment 2

[Mason Chang [Inactive] [:mchang]]

Vsync compositor on OS X passing try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=561f7c233885

Comment 3

[Mason Chang [Inactive] [:mchang]]

Try looks good on OS X + Windows with all of Silk enabled - https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa339e4699fd

Comment 4

[Johannes Pfrang [:johnp]]

Is there a bug filed for graphical corruption/artifacts after enabling vsync?

Comment 5

[Mason Chang [Inactive] [:mchang]]

(In reply to Johannes Pfrang [:johnp] from comment #4)
> Is there a bug filed for graphical corruption/artifacts after enabling vsync?

Not at the moment, but you can file one as a dependent of this bug. What are you seeing?

You can also always disable it by setting these prefs to false on b2g:

gfx.vsync.hw-vsync.enabled
gfx.vsync.compositor
gfx.touch.resample

Comment 7

[Mason Chang [Inactive] [:mchang]]

Attachment: Consoildate silk preferences

Once bug 1151488 lands, silk will be on everywhere. Hardware vsync on b2g kit-kat, Windows w/ DWM, and OS X. Software vsync everywhere else. Consolidate all the preferences into one place.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8590884 [details] [diff] [review]
Consoildate silk preferences

Review of attachment 8590884 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +4666,5 @@
>  #endif
>  
>  // Use vsync aligned rendering. b2g prefs are in b2g.js.
>  // Hardware vsync supported on windows, os x, and b2g.
>  // Linux and fennec will use software vsync.

I think just remove this entire comment block except for the first sentence. The rest of it may easily go out of date since people fiddling in other parts of the code may not update this. (The bits about b2g are already wrong/incomplete)

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1023edc0a85e

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1023edc0a85e