Closed
Bug 1151676
Opened 10 years ago
Closed 10 years ago
[MSE] Add missing ^headers^ files to tests
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
13.24 KB,
patch
|
jya
:
review+
|
Details | Diff | Splinter Review |
Some EME tests are missing ^headers^ files matching mp4 and m4s fragments, which could cause cache issues with the test server.
It might be the cause of some intermittent test failures as the server would sometimes feed the wrong contents.
Assignee | ||
Comment 1•10 years ago
|
||
Typo in description: *MSE* tests, not EME (there's bug 1151665 for these).
Assignee | ||
Comment 2•10 years ago
|
||
Added missing ^headers^ for MSE test files.
Attachment #8588878 -
Flags: review?(jyavenard)
Assignee | ||
Comment 3•10 years ago
|
||
Updated•10 years ago
|
Attachment #8588878 -
Flags: review?(jyavenard) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Keywords: checkin-needed
Comment 5•10 years ago
|
||
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5e4ea3189ff7 seems one of this changes caused frequent test failures like:
https://treeherder.mozilla.org/logviewer.html#?job_id=8536619&repo=mozilla-inbound
Flags: needinfo?(gsquelart)
Assignee | ||
Comment 6•10 years ago
|
||
I don't believe these ^header^ files are the cause of already-known intermittent failures, in fact they could only help remove some of them.
Flags: needinfo?(gsquelart)
Assignee | ||
Comment 7•10 years ago
|
||
The test failures were all in EME tests.
This patch here only touches non-EME MSE tests, so it should be safe to check-in again.
EME test failures will be dealt with in bug 1151665.
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•