Blacklist older intel drivers for DXVA

RESOLVED FIXED in Firefox 37

Status

()

Core
Audio/Video
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

(Blocks: 1 bug)

29 Branch
mozilla40
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox37+ fixed, firefox38 fixed, firefox39 fixed, firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8588932 [details] [diff] [review]
blacklist-dxva-intel

We seem to be getting a lot of reports of black video on youtube with intel GPU's and older drivers.

We've confirmed locally that 8.15.10.2279 is broken, and 8.15.10.2622 works. We'll blacklist everything before 2622 since the most accurate data we have available currently.
Attachment #8588932 - Flags: review?(ajones)
Comment on attachment 8588932 [details] [diff] [review]
blacklist-dxva-intel

Review of attachment 8588932 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/GfxInfo.cpp
@@ +1103,5 @@
>  
> +    APPEND_TO_DRIVER_BLOCKLIST2(DRIVER_OS_ALL,
> +      (nsAString&)GfxDriverInfo::GetDeviceVendor(VendorIntel), GfxDriverInfo::allDevices,
> +      nsIGfxInfo::FEATURE_HARDWARE_VIDEO_DECODING, nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
> +      DRIVER_LESS_THAN, V(8,15,10,22622));

s/22622/2622/
Attachment #8588932 - Flags: review?(ajones) → review+
(Assignee)

Comment 2

2 years ago
Comment on attachment 8588932 [details] [diff] [review]
blacklist-dxva-intel

Approval Request Comment
[Feature/regressing bug #]: HTML5 Video
[User impact if declined]: Black video on youtube when MSE gets enabled.
[Describe test coverage new/current, TreeHerder]: Manually tested and confirmed that 2622 driver works.
[Risks and why]: Low risk, just a blacklist change.
[String/UUID change made/needed]: None
Attachment #8588932 - Flags: approval-mozilla-release?
Attachment #8588932 - Flags: approval-mozilla-beta?
Attachment #8588932 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 3

2 years ago
 https://hg.mozilla.org/integration/mozilla-inbound/rev/19bbae14c606
status-firefox37: --- → affected
status-firefox38: --- → affected
status-firefox39: --- → affected
status-firefox40: --- → affected
https://hg.mozilla.org/mozilla-central/rev/19bbae14c606
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Blocks: 1150622
Comment on attachment 8588932 [details] [diff] [review]
blacklist-dxva-intel

Should be in 38 beta 3.
Attachment #8588932 - Flags: approval-mozilla-beta?
Attachment #8588932 - Flags: approval-mozilla-beta+
Attachment #8588932 - Flags: approval-mozilla-aurora?
Attachment #8588932 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/b560bd6dba33
status-firefox39: affected → fixed
Ran afoul of bug 1149343. Backed out and re-landed with that fixed.
https://hg.mozilla.org/releases/mozilla-aurora/rev/a8f5e241cb6f
https://hg.mozilla.org/releases/mozilla-aurora/rev/7be40dfbc869
status-firefox38: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/d4e6fe0b0eb5
Blocks: 1152630
[Tracking Requested - why for this release]:

If we release a 37.0.2 chemspill, we will want this GPU blocklist fix. We would no longer need hotfix bug 1152630.
tracking-firefox37: --- → ?
Sylvestre, Lawrence said said a 37.0.2 release may go to build as early as April 14. I wanted to make sure we can get this GPU blocklist changes in 37.0.2 so we don't need the hotfix in bug 1152630.
Flags: needinfo?(sledru)
Comment on attachment 8588932 [details] [diff] [review]
blacklist-dxva-intel

Sure. I guess Lawrence was going to approve it, so, I am approving it for you to make sure it lands soon.
Flags: needinfo?(sledru)
Attachment #8588932 - Flags: approval-mozilla-release? → approval-mozilla-release+
tracking-firefox37: ? → +
https://hg.mozilla.org/releases/mozilla-release/rev/29e130e0b166
status-firefox37: affected → fixed
I've tried to verify if blacklisting works through the aid of spoofing graphics data, on a Windows 7 x64 machine. I did not notice any change for the "media.windows-media-foundation.use-dxva" pref or the "GPU Accelerated Windows" value in about:support, when trying driver versions that should be blocked or unblocked. The actual steps to test this are below. 

Am I looking for the wrong things to verify here? Maybe this method of spoofing cannot be used to verify DXVA blocking?

Steps to verify:
1. Firefox 37.0.2 is installed at some location.
2. Create "spoofed-firefox.bat" file with following content (pointing to location of Firefox 37.0.2):
SET MOZ_GFX_SPOOF_WINDOWS_VERSION=60001
SET MOZ_GFX_SPOOF_VENDOR_ID=0x8086
SET MOZ_GFX_SPOOF_DEVICE_ID=0x8108
SET MOZ_GFX_SPOOF_DRIVER_VERSION=8.15.10.2222
"G:\Mozilla\37.0.2\firefox.exe" -p -no-remote
3. Open "spoofed-firefox.bat" to launch Firefox 37.0.2, create a new profile, start Firefox 37.0.2, and verify "about:support" and "about:config".

I've used the method above to successfully verify blacklisting for other features like D2D, OMTC, WebGL.
Matt - Can you answer Florin's question in comment 13?
Flags: needinfo?(matt.woodrow)
(Assignee)

Comment 15

2 years ago
We don't report DXVA status in about:support, nor will the blacklist actually change the pref.

I'm not sure how we can verify this without one of the affected machines (or by checking if DXVA is being used with a debugger).

We should make sure we report DXVA status somewhere for the future.
Flags: needinfo?(matt.woodrow)

Comment 16

2 years ago
(In reply to Matt Woodrow (:mattwoodrow) from comment #15)
> We should make sure we report DXVA status somewhere for the future.

Can you make sure you have a bug on file for this and put in your plans?
Flags: needinfo?(matt.woodrow)
(Assignee)

Updated

2 years ago
Depends on: 1151611
(Assignee)

Comment 17

2 years ago
Bug 1151611 covers doing that.
Flags: needinfo?(matt.woodrow)
You need to log in before you can comment on or make changes to this bug.