Closed Bug 1151804 Opened 5 years ago Closed 5 years ago
Candy Crush Saga doesn't load with dom
.ipc .plugins .async Init set to true
I'm on Nightly with e10s off. Trying to play Candy Crush Saga (from Facebook), the app won't load, it gets stuck at 78% (when it probably do something different, like load something from elsewhere, I don't know).
I discovered that some plugin streams are being terminated prematurely when async init is on. The crux of the problem is that nsNPAPIPluginStreamListener::OnStartBinding is not always called when you would think it would be called by Necko; sometimes the underlying request has already completed. I've got a patch written that works for Candy Crush Saga but obviously I want to test it out a bit with other content.
Comment on attachment 8591871 [details] [diff] [review] Prevent premature stream termination Review of attachment 8591871 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/plugins/ipc/PluginAsyncSurrogate.cpp @@ +171,5 @@ > aFuncs->setvalue = &NPP_SetValue; > aFuncs->newstream = &NPP_NewStream; > aFuncs->setwindow = &NPP_SetWindow; > aFuncs->writeready = &NPP_WriteReady; > + aFuncs->write = &NPP_Write; This is set about 5 lines below to |&PluginModuleParent::NPP_Write| so this line doesn't appear to have any affect. Is that right?
Duh, that's silly of me. Fixed that. I also replaced the two bools that I added to the listener with an enum.
Comment on attachment 8592314 [details] [diff] [review] Prevent premature stream termination (r2) Approval Request Comment [Feature/regressing bug #]: async plugin init [User impact if declined]: Plugins don't start properly, particularly Candy Crush Saga or other big games. This patch should also improve stability, so there would be unfixed stability problems. [Describe test coverage new/current, TreeHerder]: Tested with local and nightly builds with asyncInit enabled. [Risks and why]: Low. Simple patch that makes the browser more conservative with respect to terminating plugin streams. [String/UUID change made/needed]: None
Attachment #8592314 - Flags: approval-mozilla-aurora?
Florin, can your team test this fix on nightly before we uplift it? Aaron, what other games might be useful to test?
(In reply to Liz Henry (:lizzard) from comment #8) > Aaron, what other games might be useful to test? Any game that is takes a while to start because it has a bunch of assets that need to be downloaded. FarmVille and other popular Facebook games are also good candidates.
Verified as fixed using the following environment: FF 40 Build Id: 20150416030209 OS: Win 7 x64
Comment on attachment 8592314 [details] [diff] [review] Prevent premature stream termination (r2) Approving for uplift to aurora.
Attachment #8592314 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Backed out for test_pluginstream_err.html crashes. https://hg.mozilla.org/releases/mozilla-aurora/rev/a1d5331b1823 https://treeherder.mozilla.org/logviewer.html#?job_id=772938&repo=mozilla-aurora
u-a-f according to ASAN: https://treeherder.mozilla.org/logviewer.html#?job_id=773028&repo=mozilla-aurora
Relanded along with bug 1155503 uplift. https://hg.mozilla.org/releases/mozilla-aurora/rev/6b316eabf6e1
I verified this fix using: FF 39.0b2 Build Id: 20150601171003 OS: Win 7 x64, Mac Os X 10.9.5 and I've encountered an issue, candy crush saga is not completely loading when using a new profile, I've logged bug 1170486 for this issues.
You need to log in before you can comment on or make changes to this bug.