1151804 - Candy Crush Saga doesn't load with dom.ipc.plugins.asyncInit set to true

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Guilherme Lima]

I'm on Nightly with e10s off.
Trying to play Candy Crush Saga (from Facebook), the app won't load, it gets stuck at 78% (when it probably do something different, like load something from elsewhere, I don't know).

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

I discovered that some plugin streams are being terminated prematurely when async init is on. The crux of the problem is that nsNPAPIPluginStreamListener::OnStartBinding is not always called when you would think it would be called by Necko; sometimes the underlying request has already completed. I've got a patch written that works for Candy Crush Saga but obviously I want to test it out a bit with other content.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Prevent premature stream termination

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8591871 [details] [diff] [review]
Prevent premature stream termination

Review of attachment 8591871 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginAsyncSurrogate.cpp
@@ +171,5 @@
>    aFuncs->setvalue = &NPP_SetValue;
>    aFuncs->newstream = &NPP_NewStream;
>    aFuncs->setwindow = &NPP_SetWindow;
>    aFuncs->writeready = &NPP_WriteReady;
> +  aFuncs->write = &NPP_Write;

This is set about 5 lines below to |&PluginModuleParent::NPP_Write| so this line doesn't appear to have any affect. Is that right?

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Prevent premature stream termination (r2)

Duh, that's silly of me. Fixed that. I also replaced the two bools that I added to the listener with an enum.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fdd746ef10bd

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fdd746ef10bd

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8592314 [details] [diff] [review]
Prevent premature stream termination (r2)

Approval Request Comment
[Feature/regressing bug #]: async plugin init
[User impact if declined]: Plugins don't start properly, particularly Candy Crush Saga or other big games. This patch should also improve stability, so there would be unfixed stability problems.
[Describe test coverage new/current, TreeHerder]: Tested with local and nightly builds with asyncInit enabled.
[Risks and why]: Low. Simple patch that makes the browser more conservative with respect to terminating plugin streams.
[String/UUID change made/needed]: None

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Florin, can your team test this fix on nightly before we uplift it?  

Aaron, what other games might be useful to test?

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 39+

Comment 10

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Liz Henry (:lizzard) from comment #8)
> Aaron, what other games might be useful to test?

Any game that is takes a while to start because it has a bunch of assets that need to be downloaded. FarmVille and other popular Facebook games are also good candidates.

Comment 11

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 40
Build Id: 20150416030209
OS: Win 7 x64

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8592314 [details] [diff] [review]
Prevent premature stream termination (r2)

Approving for uplift to aurora.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7c2d250ea3f2

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Backed out for test_pluginstream_err.html crashes.
https://hg.mozilla.org/releases/mozilla-aurora/rev/a1d5331b1823

https://treeherder.mozilla.org/logviewer.html#?job_id=772938&repo=mozilla-aurora

Comment 15

[(No longer employed by Mozilla) Aaron Klotz]

Ha! Looks like we hit bug 1155503.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

u-a-f according to ASAN:
https://treeherder.mozilla.org/logviewer.html#?job_id=773028&repo=mozilla-aurora

Comment 17

[(No longer employed by Mozilla) Aaron Klotz]

Relanded along with bug 1155503 uplift.
https://hg.mozilla.org/releases/mozilla-aurora/rev/6b316eabf6e1

Comment 18

[Catalin Varga [QA][:VarCat]]

I verified this fix using:

FF 39.0b2
Build Id: 20150601171003
OS: Win 7 x64, Mac Os X 10.9.5

and I've encountered an issue, candy crush saga is not completely loading when using a new profile, I've logged bug 1170486 for this issues.