1151843 - [Messages][Refactoring] Use notification "data" attribute instead of icon URL query string parameters

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

After patch for bug 899585, notification options have dedicated "data" attribute to associate custom data with notification object. So we should stop abusing icon URL attribute to store custom data and start using "data" instead.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1151843-notification-data > mozilla-b2g:master

Comment 2

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8589252 [details] [review]
[gaia] azasypkin:bug-1151843-notification-data > mozilla-b2g:master

Hey Julien, could you please review this patch?

I've split it into two commits, 2nd one is just further improvement of onNotification handler, I'm still not sure if it worth creating separate bug for it, but let me know what you think.

Thanks!

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8589252 [details] [review]
[gaia] azasypkin:bug-1151843-notification-data > mozilla-b2g:master

r=me for the first commit only.

Please handle the comment about the shared Notification mock if you think it's good and it's not breaking other tests, but I'm not blocking on this.

Comment 4

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8589252 [details] [review]
[gaia] azasypkin:bug-1151843-notification-data > mozilla-b2g:master

Hey Michael,

In this patch I modified  shared/test/unit/mocks/mock_notification.js a bit, could you please let me know if it looks OK for you?

Thanks!

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8589252 [details] [review]
[gaia] azasypkin:bug-1151843-notification-data > mozilla-b2g:master

Looks fine, thanks!

Comment 6

[Oleg Zasypkin [:azasypkin]]

Thanks for review guys!

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/337d585be50784127d45d33d019be94d86d43773