Closed Bug 1153784 Opened 10 years ago Closed 9 years ago

[Messages][Refactoring] Use Promise-based syntax for navigator.mozApps.getSelf in ActivityHandler

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1208532

People

(Reporter: azasypkin, Assigned: anubhav.worklinux, Mentored)

References

Details

(Whiteboard: [lang=js][good first bug])

This minor improvement can make uplifting changes to older branches a bit more cumbersome, but still will makes code cleaner.
The code is in the file activity_handler.js. The goal is to replace the "onsuccess" handler by a call to the then-method that the DOMRequest gives us for some time.
Mentor: azasypkin
Whiteboard: [lang=js][good first bug]
Hi! I would like to work on this one.
(In reply to anubhav.worklinux from comment #2) > Hi! I would like to work on this one. Great! In addition to what Julien mentioned in comment 1, you'll likely need to update shared (used by other apps as well, so be careful) "getSelf" mock [1]. If you find a good way to change activity_handler unit tests without updating shared mock - it will work for me as well :) ni? me here or ping on #gaia IRC channel in case you have any questions. Thanks! [1] https://github.com/azasypkin/gaia/blob/master/shared/test/unit/mocks/mock_navigator_moz_apps.js
Assignee: nobody → anubhav.worklinux
Status: NEW → ASSIGNED
Hey Anubhav, How are you doing on bug? Any update? Feel free to reach out to irc or here for any help :). Thanks
Flags: needinfo?(anubhav.worklinux)
Hi rishav, Right now i'm busy with my engineering sessionals, i'll submit a patch as soon as they are over. i've done the promise-based syntax part, now only need to figure out the unit test part. would surely get on irc with my doubts. Thanks
Flags: needinfo?(anubhav.worklinux)
(In reply to anubhav.worklinux from comment #5) > Hi rishav, > Right now i'm busy with my engineering sessionals, i'll submit a patch as > soon as they are over. > i've done the promise-based syntax part, now only need to figure out the > unit test part. > would surely get on irc with my doubts. > > Thanks Hey Anubhav, Thanks for working on this! Unfortunately this task was a blocker for us in another ongoing and long standing bug 1208532, so we had to solve it there by ourselves. So will be happy to help you to find another good bug once you have some spare time :) Thanks for understanding!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.