1153784 - [Messages][Refactoring] Use Promise-based syntax for navigator.mozApps.getSelf in ActivityHandler

Status: RESOLVED DUPLICATE of bug 1208532

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

This minor improvement can make uplifting changes to older branches a bit more cumbersome, but still will makes code cleaner.

Comment 1

[Julien Wajsberg [:julienw]]

The code is in the file activity_handler.js. The goal is to replace the "onsuccess" handler by a call to the then-method that the DOMRequest gives us for some time.

Comment 2

[anubhav.worklinux]

Hi! I would like to work on this one.

Comment 3

[Oleg Zasypkin [:azasypkin]]

(In reply to anubhav.worklinux from comment #2)
> Hi! I would like to work on this one.

Great!

In addition to what Julien mentioned in comment 1, you'll likely need to update shared (used by other apps as well, so be careful) "getSelf" mock [1]. If you find a good way to change activity_handler unit tests without updating shared mock - it will work for me as well :)

ni? me here or ping on #gaia IRC channel in case you have any questions.

Thanks!

[1] https://github.com/azasypkin/gaia/blob/master/shared/test/unit/mocks/mock_navigator_moz_apps.js

Comment 4

[kumar rishav (:rishav_)]

Hey Anubhav,
How are you doing on bug? Any update? Feel free to reach out to irc or here for any help :).

Thanks

Comment 5

[anubhav.worklinux]

Hi rishav,
Right now i'm busy with my engineering sessionals, i'll submit a patch as soon as they are over.
i've done the promise-based syntax part, now only need to figure out the unit test part.
would surely get on irc with my doubts.

Thanks

Comment 6

[Oleg Zasypkin [:azasypkin]]

(In reply to anubhav.worklinux from comment #5)
> Hi rishav,
> Right now i'm busy with my engineering sessionals, i'll submit a patch as
> soon as they are over.
> i've done the promise-based syntax part, now only need to figure out the
> unit test part.
> would surely get on irc with my doubts.
> 
> Thanks

Hey Anubhav,

Thanks for working on this! Unfortunately this task was a blocker for us in another ongoing and long standing bug 1208532, so we had to solve it there by ourselves.

So will be happy to help you to find another good bug once you have some spare time :)

Thanks for understanding!