1151993 - apply shrink-wrapping to orthogonal block frames

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: Testcase

See attached testcase. For the vertical <div> between the two horizontal paragraphs, we use the height of the outer containing <div> as its available isize, which is a good start. But when it contains only a small amount of text (right-hand example) we should shrink-wrap it instead of maintaining the containing block's height as a fixed inline-size for the orthogonal block.

(This is what webkit/blink does.)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Apply shrink-wrapping to block frames that are orthogonal to their containing block

This seems to make the example behave as desired.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does this match what the spec says to do?

Comment 3

[Jonathan Kew [:jfkthame]]

(In reply to David Baron [:dbaron] ⏰UTC-7 from comment #2)
> Does this match what the spec says to do?

I think so, as best I can understand it. In particular, "If a box establishing an orthogonal flow is a block container ... for the case where the box’s inline size is auto: ... if the content neither line-wraps nor fragments ... the used inline size is the max-content inline size of the box’s contents".[1] Which I take to mean that the used height of the "Hello World" block in the example here is simply the length of the "Hello World" text.

[1] http://dev.w3.org/csswg/css-writing-modes/#auto-multicol

Comment 4

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6058eb085f1

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Reftest for inline-sizing of orthogonal block frames

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: Fix the reference for 1124636-2-fieldset-min-height to match new behavior

Turns out the patch here causes an existing test to fail, but in this case that's OK: the corrected behavior makes far more sense, and we should just fix the reference file to reflect the new reality.

Comment 7

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36026abf6c53
https://hg.mozilla.org/integration/mozilla-inbound/rev/314f615d272b
https://hg.mozilla.org/integration/mozilla-inbound/rev/27220470506a

Comment 8

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/52e5ad1e8863

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/36026abf6c53
https://hg.mozilla.org/mozilla-central/rev/314f615d272b
https://hg.mozilla.org/mozilla-central/rev/27220470506a
https://hg.mozilla.org/mozilla-central/rev/52e5ad1e8863