Closed Bug 1152151 Opened 5 years ago Closed 5 years ago

[EME] Some tests keep working after they should have finished

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Some EME tests keep doing some work after they have first declared themselves finished, e.g.:
https://treeherder.mozilla.org/logviewer.html#?job_id=6292556&repo=try
"23:09:54 INFO - 331 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_eme_canvas_blocked.html | bipbop-cenc-videoinit.mp4-2 fragment 'bipbop-cenc-audio3.m4s' size: expected 977, got 977 - Result logged after SimpleTest.finish()"

This is because "LoadTest(test, v, token)" asynchronously loads all the fragments for each test case, but the test themselves only check pass/fail conditions early (typically after the init segments) and declare the test finished. But loading continues in the background, and some checks are done there, which could result in late errors.

Possible solutions:
1. Don't mark the test 'finished' until loading has completed.
2. Only try to load the segments needed for each test.
3. Allow the test to stop the loading operation.
Blocks: 1152153
Summary: [EME] Some tests keep checking things after they should be finished → [EME] Some tests keep working after they should have finished
Added manager.started(token+"_load") and manager.finished(token+"_load") around TestLoad to ensure that test don't terminate tests too quickly while fetching is still running.
Attachment #8589523 - Flags: review?(edwin)
No longer blocks: 1152153
Rebase & patch rename, no actual changes, carrying r+.
Attachment #8589523 - Attachment is obsolete: true
Attachment #8592552 - Flags: review+
Some tests only need the init fragment and the first data fragment, no need to load more.
Attachment #8592553 - Flags: review?(edwin)
No longer depends on: 1151693
https://hg.mozilla.org/mozilla-central/rev/c55cbfbc2a24
https://hg.mozilla.org/mozilla-central/rev/03406fe40cc9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.