1152153 - [EME] test_eme_persistent_sessions does not handle multi-stream cases

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

test_eme_persistent_sessions.html was only designed to handle one session at a time.
Some failures (e.g. bug 1148844) may be related to this.

Possible solutions:
1. Only use test cases with 1 session.
2. Modify code to handle multiple sessions.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Can you elaborate the problem? I think we should support multiple sessions in the real use case and our test case should also reflect the truth.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

The test was originally written at a time when there were only single-stream test cases, and it has some top-level variables meant to be used by 'the' session handler.
So when two sessions are created (as is the case in multi-stream videos since bug 1144409) the same variables are used by both session handlers, with some unexpected results that do not necessarily point to real code issues.

I agree that handling multiple sessions is expected, and will try to patch the test that way.
But in the worst case (too hard?), I'll fall back to option 1 for now and create a separate bug to later handle multi-stream tests.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

eme.js:SetupEME() itself does not handle multiple sessions well, so this bug here will just disable multi-session test cases for now.
After bug 1142379 lands with real multi-stream tests, bug 1152170 will add full support for multi-stream tests in test_eme_persistent_sessions.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1152153-eme-persistent-test-single-sessions-only.patch

Only use test cases that generate 1 session.

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc8db5b4a63b

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/395ef92d464f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for test_eme_persistent_sessions.html timeouts on multiple platforms.
https://hg.mozilla.org/integration/mozilla-inbound/rev/82fc1964041c

https://treeherder.mozilla.org/logviewer.html#?job_id=8683992&repo=mozilla-inbound

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Trying with patch from bug 1154133:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=19326a3604ff

Comment 9

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1152153-eme-persistent-test-single-sessions-only.patch

Rebase, no actual changes, carrying r+.

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/865713e00111

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/865713e00111