Closed Bug 1152153 Opened 5 years ago Closed 5 years ago

[EME] test_eme_persistent_sessions does not handle multi-stream cases

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

test_eme_persistent_sessions.html was only designed to handle one session at a time.
Some failures (e.g. bug 1148844) may be related to this.

Possible solutions:
1. Only use test cases with 1 session.
2. Modify code to handle multiple sessions.
Can you elaborate the problem? I think we should support multiple sessions in the real use case and our test case should also reflect the truth.
The test was originally written at a time when there were only single-stream test cases, and it has some top-level variables meant to be used by 'the' session handler.
So when two sessions are created (as is the case in multi-stream videos since bug 1144409) the same variables are used by both session handlers, with some unexpected results that do not necessarily point to real code issues.

I agree that handling multiple sessions is expected, and will try to patch the test that way.
But in the worst case (too hard?), I'll fall back to option 1 for now and create a separate bug to later handle multi-stream tests.
eme.js:SetupEME() itself does not handle multiple sessions well, so this bug here will just disable multi-session test cases for now.
After bug 1142379 lands with real multi-stream tests, bug 1152170 will add full support for multi-stream tests in test_eme_persistent_sessions.
Only use test cases that generate 1 session.
Attachment #8589526 - Flags: review?(edwin)
Rebase, no actual changes, carrying r+.
Attachment #8589526 - Attachment is obsolete: true
Attachment #8592554 - Flags: review+
No longer depends on: 1154133
https://hg.mozilla.org/mozilla-central/rev/865713e00111
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.