Closed
Bug 1152181
Opened 10 years ago
Closed 10 years ago
Update log captured notification
Categories
(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect)
Firefox OS Graveyard
Gaia::Bugzilla Lite
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S10 (17apr)
People
(Reporter: daleharvey, Assigned: daleharvey)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
change 1st line to “Device logs saved”
replace 2nd line with date and change to “Tap to share logs”
Assignee | ||
Updated•10 years ago
|
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Hey Alexandre
Talked about this during a UX review of bzlite and UX wanted to change these strings to hopefully be a little more user friendly
Attachment #8589594 -
Flags: review?(lissyx+mozillians)
Comment 3•10 years ago
|
||
Comment on attachment 8589594 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/29393
Looks ok, I've just left a comment regarding the way localization is done :)
Attachment #8589594 -
Flags: review?(lissyx+mozillians) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Thanks, addressed nit
Fixed in https://github.com/mozilla-b2g/gaia/commit/6e3d8514d7fe3a77ecde3e031104d5f6a9186142
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•10 years ago
|
||
Reverted in https://github.com/mozilla-b2g/gaia/commit/39b956dcc78c141af1c6524c9ac8c015cd6bb6fa, I forgot to address unit test changes, apologies
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•10 years ago
|
||
(In reply to Dale Harvey (:daleharvey) from comment #5)
> Reverted in
> https://github.com/mozilla-b2g/gaia/commit/
> 39b956dcc78c141af1c6524c9ac8c015cd6bb6fa, I forgot to address unit test
> changes, apologies
Using autolander will help fix this by running tests before it lands if you want in the future. Also you didn't need to attach the pull request again, autolander makes our lives easier now :)
Assignee | ||
Comment 7•10 years ago
|
||
Hah yeh I forgot this was on gaia, the rest of the bzlite commits are on a different repo
Fixed the issue and will land it via autolander, cheers
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/cc7d7269407177ec38aa154f79c89a40e9c5fb37
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 10•10 years ago
|
||
This doesn't work, you need to update the ID of a string if you change its content. Filed bug 1152483.
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S10 (17apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•