Closed Bug 1152181 Opened 5 years ago Closed 5 years ago

Update log captured notification

Categories

(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Bugzilla Lite
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.2 S10 (17apr)

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

[gaia] daleharvey:1152181 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review
https://github.com/mozilla-b2g/gaia/pull/29393
46 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review 
change 1st line to “Device logs saved”
    replace 2nd line with date and change to “Tap to share logs”
Assignee: nobody → dale
Blocks: 1134701
Component: Gaia::Feedback → Bugzilla Lite
Hey Alexandre

Talked about this during a UX review of bzlite and UX wanted to change these strings to hopefully be a little more user friendly
Attachment #8589594 - Flags: review?(lissyx+mozillians)
Comment on attachment 8589594 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/29393

Looks ok, I've just left a comment regarding the way localization is done :)
Attachment #8589594 - Flags: review?(lissyx+mozillians) → review+
Thanks, addressed nit

Fixed in https://github.com/mozilla-b2g/gaia/commit/6e3d8514d7fe3a77ecde3e031104d5f6a9186142
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Reverted in https://github.com/mozilla-b2g/gaia/commit/39b956dcc78c141af1c6524c9ac8c015cd6bb6fa, I forgot to address unit test changes, apologies
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Dale Harvey (:daleharvey) from comment #5)
> Reverted in
> https://github.com/mozilla-b2g/gaia/commit/
> 39b956dcc78c141af1c6524c9ac8c015cd6bb6fa, I forgot to address unit test
> changes, apologies

Using autolander will help fix this by running tests before it lands if you want in the future. Also you didn't need to attach the pull request again, autolander makes our lives easier now :)
Hah yeh I forgot this was on gaia, the rest of the bzlite commits are on a different repo

Fixed the issue and will land it via autolander, cheers
All unit tests are passing now
Keywords: checkin-needed
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
Blocks: 1152483
This doesn't work, you need to update the ID of a string if you change its content. Filed bug 1152483.
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S10 (17apr)
You need to log in before you can comment on or make changes to this bug.