1152181 - Update log captured notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect)

Description

[Dale Harvey (:daleharvey)]

change 1st line to “Device logs saved”
    replace 2nd line with date and change to “Tap to share logs”

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] daleharvey:1152181 > mozilla-b2g:master

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/29393

Hey Alexandre

Talked about this during a UX review of bzlite and UX wanted to change these strings to hopefully be a little more user friendly

Comment 3

[:gerard-majax]

Comment on attachment 8589594 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/29393

Looks ok, I've just left a comment regarding the way localization is done :)

Comment 4

[Dale Harvey (:daleharvey)]

Thanks, addressed nit

Fixed in https://github.com/mozilla-b2g/gaia/commit/6e3d8514d7fe3a77ecde3e031104d5f6a9186142

Comment 5

[Dale Harvey (:daleharvey)]

Reverted in https://github.com/mozilla-b2g/gaia/commit/39b956dcc78c141af1c6524c9ac8c015cd6bb6fa, I forgot to address unit test changes, apologies

Comment 6

[Kevin Grandon :kgrandon]

(In reply to Dale Harvey (:daleharvey) from comment #5)
> Reverted in
> https://github.com/mozilla-b2g/gaia/commit/
> 39b956dcc78c141af1c6524c9ac8c015cd6bb6fa, I forgot to address unit test
> changes, apologies

Using autolander will help fix this by running tests before it lands if you want in the future. Also you didn't need to attach the pull request again, autolander makes our lives easier now :)

Comment 7

[Dale Harvey (:daleharvey)]

Hah yeh I forgot this was on gaia, the rest of the bzlite commits are on a different repo

Fixed the issue and will land it via autolander, cheers

Comment 8

[Dale Harvey (:daleharvey)]

All unit tests are passing now

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/cc7d7269407177ec38aa154f79c89a40e9c5fb37

Comment 10

[Francesco Lodolo [:flod] (OOO July 12–20)]

This doesn't work, you need to update the ID of a string if you change its content. Filed bug 1152483.