Closed
Bug 1152209
Opened 10 years ago
Closed 10 years ago
Use "fligtar.{sf,rsa}" instead of "zigbert.{sf,rsa}" for signature files in signed addons
Categories
(addons.mozilla.org Graveyard :: Add-on Validation, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2015-04
People
(Reporter: magopian, Assigned: rtilder)
References
Details
Not sure how you want to deal with that: either changed the hardcoded filenames from zigbert.rsa to fligtar.rsa and zigbert.sf to fligtar.sf, or ask for the filename as a parameter to the "make_signed" call in https://github.com/mozilla/signing-clients/blob/master/signing_clients/apps.py#L297
This blocks bug 1152102
Comment 1•10 years ago
|
||
fligtar.rsa? Let's not use fligtar's alias in public-facing stuff, please.
Comment 2•10 years ago
|
||
It's not public facing. It's a hidden file in an XPI that no-one will ever see unless they're specifically looking for it. Which is why the NSS version is called 'zigbert'.
And fligtar is the one who kicked off this whole process like 4 years ago. Seems appropriate.
Assignee | ||
Comment 3•10 years ago
|
||
Pull request pending: https://github.com/mozilla/signing-clients/pull/15
Status: NEW → ASSIGNED
Reporter | ||
Comment 4•10 years ago
|
||
will use "mozilla" instead of "fligtar"
Assignee | ||
Comment 5•10 years ago
|
||
Pull request merged and new PyPI package available from https://pypi.python.org/pypi/signing_clients
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 6•10 years ago
|
||
Inside the META-INF the files are now named: mozilla.rsa, mozilla.sf : http://screencast.com/t/6bvDuvRP
Closing bug.
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•