Closed Bug 1152298 Opened 4 years ago Closed 4 years ago

Implement an AutoDriver for HTMLCanvasElement::CaptureStream

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox40 --- affected
firefox43 --- fixed
Blocking Flags:

People

(Reporter: pehrsons, Assigned: pehrsons)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: webrtc_spec
backlog: --- → webRTC+
Rank: 25
Priority: -- → P2
Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt
Attachment #8653331 - Flags: review?(martin.thomson)
This relies on the work done in bug 1161913.
Assignee: nobody → pehrsons
Status: NEW → ASSIGNED
Depends on: 1161913
Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

https://reviewboard.mozilla.org/r/17453/#review15835

Too easy.
Attachment #8653331 - Flags: review?(martin.thomson) → review+
Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r=mt
Attachment #8653331 - Attachment description: MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt → MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r=mt
Attachment #8653331 - Flags: review+
Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

Carrying forward r=mt.

Looking at some other review requests I thought mozreview now supported carrying over the r=. But no.
Attachment #8653331 - Flags: review+
Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt
Attachment #8653331 - Attachment description: MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r=mt → MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt
Attachment #8653331 - Flags: review+
Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

This was rebased. Carries r=mt.
Attachment #8653331 - Flags: review+
Andreas, if you have these sorts of dependencies, you should probably land them yourself.  checkin-needed is now processed by a bot, so it will miss that sort of nuance.  If you don't have L3, let me or Maire know and we can sort that out.
(In reply to Martin Thomson [:mt:] from comment #9)
> Andreas, if you have these sorts of dependencies, you should probably land
> them yourself.  checkin-needed is now processed by a bot, so it will miss
> that sort of nuance.  If you don't have L3, let me or Maire know and we can
> sort that out.

did the checkins now. There are future plans to have some kind of autolander that lands also checkin-needed requests but so far its still a human part (yes i'm still not a bot ;). So for dependencys something like here (please land bug x together with bug y helps a lot).  

Pulsebot itself is just a bot that comments with csets strings when something land on the trees :)
https://hg.mozilla.org/mozilla-central/rev/af0ad20ecd0b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.