1152298 - Implement an AutoDriver for HTMLCanvasElement::CaptureStream

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

Comment 2

[Andreas Pehrson [:pehrsons]]

This relies on the work done in bug 1161913.

Comment 3

[Martin Thomson [:mt:]]

Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

https://reviewboard.mozilla.org/r/17453/#review15835

Too easy.

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r=mt

Comment 5

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

Carrying forward r=mt.

Looking at some other review requests I thought mozreview now supported carrying over the r=. But no.

Comment 6

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

Comment 7

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8653331 [details]
MozReview Request: Bug 1152298 - Implement AutoDriver for CanvasCaptureMediaStream. r?mt

This was rebased. Carries r=mt.

Comment 8

[Andreas Pehrson [:pehrsons]]

Please land this on top of bug 1161913.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=66f8b6d742c7
And after the static analysis fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=14c31870ae46

Comment 9

[Martin Thomson [:mt:]]

Andreas, if you have these sorts of dependencies, you should probably land them yourself.  checkin-needed is now processed by a bot, so it will miss that sort of nuance.  If you don't have L3, let me or Maire know and we can sort that out.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af0ad20ecd0b

Comment 11

[Carsten Book [:Tomcat]]

(In reply to Martin Thomson [:mt:] from comment #9)
> Andreas, if you have these sorts of dependencies, you should probably land
> them yourself.  checkin-needed is now processed by a bot, so it will miss
> that sort of nuance.  If you don't have L3, let me or Maire know and we can
> sort that out.

did the checkins now. There are future plans to have some kind of autolander that lands also checkin-needed requests but so far its still a human part (yes i'm still not a bot ;). So for dependencys something like here (please land bug x together with bug y helps a lot).  

Pulsebot itself is just a bot that comments with csets strings when something land on the trees :)

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/af0ad20ecd0b