Closed Bug 1152368 Opened 5 years ago Closed 5 years ago

BUGZILLA_VERSION in Bugzill::Constants causes error when installing Perl deps for new BMO installation

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dkl, Assigned: dkl)

References

Details

Attachments

(1 file, 1 obsolete file)

BUGZILLA_VERSION() calls 'require Bugzilla' which dies if an array of perl deps are not already installed. We need to wrap this in eval and fall back to the old constant value if error.

dkl
Attached patch 1152368_1.patch (obsolete) — Splinter Review
Attachment #8589697 - Flags: review?(dylan)
Comment on attachment 8589697 [details] [diff] [review]
1152368_1.patch

Review of attachment 8589697 [details] [diff] [review]:
-----------------------------------------------------------------

r- string eval not needed.

::: Bugzilla/Constants.pm
@@ +225,5 @@
>  # BMO: we don't map exactly to a specific bugzilla version, so override our
>  # reported version with a parameter.
>  sub BUGZILLA_VERSION {
> +    my $bugzilla_version = '4.2+';
> +    eval ("require Bugzilla") || return $bugzilla_version;

there is no reason to use a string eval here. eval { require Bugzilla } should be used.
Attachment #8589697 - Flags: review?(dylan) → review-
Attached patch 1152368_2.patchSplinter Review
Attachment #8589697 - Attachment is obsolete: true
Attachment #8589708 - Flags: review?(dylan)
Comment on attachment 8589708 [details] [diff] [review]
1152368_2.patch

Review of attachment 8589708 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8589708 - Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   3eb141e..426d9ce  master -> master
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.