1152368 - BUGZILLA_VERSION in Bugzill::Constants causes error when installing Perl deps for new BMO installation

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[David Lawrence [:dkl]]

BUGZILLA_VERSION() calls 'require Bugzilla' which dies if an array of perl deps are not already installed. We need to wrap this in eval and fall back to the old constant value if error.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: 1152368_1.patch

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8589697 [details] [diff] [review]
1152368_1.patch

Review of attachment 8589697 [details] [diff] [review]:
-----------------------------------------------------------------

r- string eval not needed.

::: Bugzilla/Constants.pm
@@ +225,5 @@
>  # BMO: we don't map exactly to a specific bugzilla version, so override our
>  # reported version with a parameter.
>  sub BUGZILLA_VERSION {
> +    my $bugzilla_version = '4.2+';
> +    eval ("require Bugzilla") || return $bugzilla_version;

there is no reason to use a string eval here. eval { require Bugzilla } should be used.

Comment 3

[David Lawrence [:dkl]]

Attachment: 1152368_2.patch

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8589708 [details] [diff] [review]
1152368_2.patch

Review of attachment 8589708 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 5

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   3eb141e..426d9ce  master -> master