Treeherder models/services not reusable without dragging in UI dependencies

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

We currently only have one top-level treeherder module which drags in *everything* needed to create the default view. This makes it difficult for other applications (e.g. the logviewer or perf views) to reuse functionality from it without dragging in a lot of dependencies (i.e. the resizer, ngRouter, bootstrap, ...) -- see bug 1151337 for an example of where we'd want to do this.

Let's create a top-level treeherder module which just does model stuff, and create a treeherder.app module which brings that functionality in. That way, new views (like perf) can freely borrow the model stuff without dragging in a million dependencies.

There are probably even better ways of dividing things up, but this is easy to do. We can always build on this work later.
Created attachment 8589714 [details] [review]
PR

Hopefully this makes sense! I think it's a win in terms of modularity. Seems to work well in my testing too.
Assignee: nobody → wlachance
Attachment #8589714 - Flags: review?(cdawson)
Comment on attachment 8589714 [details] [review]
PR

This looks good to me.  Though I guess the real test will be in the.. well... testing.  But it all seems to make good sense.
Attachment #8589714 - Flags: review?(cdawson) → review+

Comment 3

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/4e553cb07e22689005594b2a0e8a87eee14b80a0
Bug 1152376 - Create a top-level treeherder module seperate from application
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Depends on: 1155330

Comment 4

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/1ca8207dd0be6961009c41b9434f1267572d41d5
Bug 1152376 - Create a top-level treeherder module seperate from application
You need to log in before you can comment on or make changes to this bug.