1152609 - Swift 1.2 compatibility changes

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Comment 1

[Richard Newman [:rnewman]]

Base32 pull request:

https://github.com/norio-nomura/Base32/pull/10

Comment 3

[Richard Newman [:rnewman]]

SwiftKeychainWrapper pull request:

https://github.com/jrendel/SwiftKeychainWrapper/pull/12

Comment 4

[Richard Newman [:rnewman]]

Base32 and SwiftKeychainWrapper PRs merged.

st3fan's SWXML fork has my Swift 1.2 fixes, too. Nearly there.

Comment 5

[Richard Newman [:rnewman]]

Attachment: Pull req.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This looks good. Should we coordinate this with the whole team before we do this? I'm all for doing this sooner than later.

Comment 7

[Richard Newman [:rnewman]]

Just to keep the bug up-to-date: there are a pile more fixes in my PR, and Stefan is carrying this forward to fix some broken stuff:

08:58:59 <@st3fan> bnicholson: i think the TwoCell* stuff needs a rewrite .. it is not very compatible with swift 1.2 anymore
09:12:55 <@st3fan> one more followup patch
09:13:32 <@st3fan> the LongPressGestureRecoginizer is badly organized and i don't really see how to easily turn that into swift 1.2 compatible code
09:14:23 <@st3fan> on second thought, it is fundamentally wrong to subclass UILongPressGestureRecoginizer and put logic and a reference to a webview in it
09:14:28 <@st3fan> needs a rewrite :-/
09:16:35 <@st3fan> this suffers from the same flaws as the TwoCell* views .. you can't use self before a call to super.init() and they have a circular init dependency that jsut wont resolve in 1.2
09:20:11 <@st3fan> no we just need it to cancel out the original recoginzer that is on the WKWebView
09:20:31 <@st3fan> but the actual press handling logic should move into BVC probably
09:20:55 <@st3fan> i'll attack this - need to grab some lunch first , then i'll fix this


His branch is at:

https://github.com/mozilla/firefox-ios/commits/mozilla-rnewman/swift-1.2

Comment 8

[Richard Newman [:rnewman]]

Landed:

https://github.com/mozilla/firefox-ios/commit/6465cf39150b7da0fbc1d48b7434f039d738d162

I also fixed some deprecation warnings around calendar fields, and I set SWIFT_WHOLE_MODULE_OPTIMIZATION.

Tests pass on my 8.2 device.