https://github.com/mozilla/firefox-ios/pull/325 Wes and Brian had some nits.
I'd be willing to take these on.
Assignee: nobody → aeriklawson
Status: NEW → ASSIGNED
Attachment #8741588 - Flags: review?(rnewman) → review?(bnicholson)
Comment on attachment 8741588 [details] [review] Pull request Thanks for the changes! These changes look good for the most part, but note that you're working off of a very old HEAD (the parent commit to your changes is f5ab6aa, from April 2015). Please rebase your changes onto the latest master and force push to update this PR. Also, please squash all of these commits into one; they're all related to a single follow-up, so no need to split them. After that, I think this should be good to go!
Attachment #8741588 - Flags: review?(bnicholson) → feedback+
Geez, my brain thought it was still 2015 - everything makes much more sense now, haha. Okay, it was easier to just trash that branch and make a new one. Most of the changes were overtaken, but I did change a function signature that hadn't been fixed yet (some whitespace changes made their way in too).
Attachment #8741588 - Attachment is obsolete: true
Attachment #8741909 - Flags: review?(bnicholson) → review+
You need to log in before you can comment on or make changes to this bug.