Closed
Bug 1153081
Opened 9 years ago
Closed 8 years ago
Fix nits from Bug 1152609 (Swift 1.2 changes)
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios-v5.0 | --- | fixed |
People
(Reporter: rnewman, Assigned: aeriklawson, Mentored)
References
Details
(Whiteboard: [good first bug][lang=swift])
Attachments
(1 file, 1 obsolete file)
https://github.com/mozilla/firefox-ios/pull/325 Wes and Brian had some nits.
Assignee | ||
Comment 1•8 years ago
|
||
I'd be willing to take these on.
Updated•8 years ago
|
Assignee: nobody → aeriklawson
Mentor: wjohnston2000
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8741588 -
Flags: review?(rnewman)
Reporter | ||
Updated•8 years ago
|
Attachment #8741588 -
Flags: review?(rnewman) → review?(bnicholson)
Comment 3•8 years ago
|
||
Comment on attachment 8741588 [details] [review] Pull request Thanks for the changes! These changes look good for the most part, but note that you're working off of a very old HEAD (the parent commit to your changes is f5ab6aa, from April 2015). Please rebase your changes onto the latest master and force push to update this PR. Also, please squash all of these commits into one; they're all related to a single follow-up, so no need to split them. After that, I think this should be good to go!
Attachment #8741588 -
Flags: review?(bnicholson) → feedback+
Assignee | ||
Comment 4•8 years ago
|
||
Geez, my brain thought it was still 2015 - everything makes much more sense now, haha. Okay, it was easier to just trash that branch and make a new one. Most of the changes were overtaken, but I did change a function signature that hadn't been fixed yet (some whitespace changes made their way in too).
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8741909 -
Flags: review?(bnicholson)
Updated•8 years ago
|
Attachment #8741588 -
Attachment is obsolete: true
Comment 6•8 years ago
|
||
https://github.com/mozilla/firefox-ios/commit/05946639b1eb2326a3f94e2a2edf31f085eb6d7c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-fxios-v5.0:
--- → fixed
Resolution: --- → FIXED
Updated•8 years ago
|
Attachment #8741909 -
Flags: review?(bnicholson) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•