New mail sound preview doesn't work for default system sound on Mac OS X

RESOLVED FIXED in Thunderbird 40.0

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sshagarwal, Assigned: sshagarwal)

Tracking

unspecified
Thunderbird 40.0
x86
macOS

Thunderbird Tracking Flags

(thunderbird38 fixed, thunderbird39 fixed, thunderbird40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

4 years ago
No sound is heard when the new mail sound preview button is pressed for default system sound on Mac OS.

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsISound#playSystemSound() suggests that playSystemSound isn't supported on Macintosh.
Assignee

Comment 1

4 years ago
Posted patch Patch v1 (obsolete) — Splinter Review
The issue and the fix is similar to the one on bug 1141932 and bug 1144256.

Thanks.
Attachment #8590418 - Flags: review?(mconley)

Comment 2

4 years ago
Comment on attachment 8590418 [details] [diff] [review]
Patch v1

Review of attachment 8590418 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/preferences/general.js
@@ +115,5 @@
> +    if (!soundLocation.contains("file://")) {
> +      if (Services.appinfo.OS == "Darwin") // OS X
> +        sound.beep();
> +      else
> +        sound.playEventSound(Ci.nsISound.EVENT_NEW_MAIL_RECEIVED);

Are you sure Ci is defined here? The rest of the file uses Components.interfaces.

Updated

4 years ago
Attachment #8590418 - Flags: review?(mconley) → review-
Assignee

Comment 3

4 years ago
Posted patch Patch v1.2Splinter Review
Oh sorry, missed that.
Attachment #8590418 - Attachment is obsolete: true
Attachment #8598617 - Flags: review?(aleth)

Comment 4

4 years ago
Comment on attachment 8598617 [details] [diff] [review]
Patch v1.2

Thanks!
Attachment #8598617 - Flags: review?(aleth) → review+

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Attachment #8598617 - Flags: approval-comm-beta?
Attachment #8598617 - Flags: approval-comm-aurora?

Updated

4 years ago
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in before you can comment on or make changes to this bug.