1152926 - New mail sound preview doesn't work for default system sound on Mac OS X

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Suyash Agarwal (:sshagarwal)]

No sound is heard when the new mail sound preview button is pressed for default system sound on Mac OS.

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsISound#playSystemSound() suggests that playSystemSound isn't supported on Macintosh.

Comment 1

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v1

The issue and the fix is similar to the one on bug 1141932 and bug 1144256.

Thanks.

Comment 2

[aleth [:aleth]]

Comment on attachment 8590418 [details] [diff] [review]
Patch v1

Review of attachment 8590418 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/preferences/general.js
@@ +115,5 @@
> +    if (!soundLocation.contains("file://")) {
> +      if (Services.appinfo.OS == "Darwin") // OS X
> +        sound.beep();
> +      else
> +        sound.playEventSound(Ci.nsISound.EVENT_NEW_MAIL_RECEIVED);

Are you sure Ci is defined here? The rest of the file uses Components.interfaces.

Comment 3

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v1.2

Oh sorry, missed that.

Comment 4

[aleth [:aleth]]

Comment on attachment 8598617 [details] [diff] [review]
Patch v1.2

Thanks!

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/31f4e46fa201

Comment 6

[Kent James (:rkent)]

Comment on attachment 8598617 [details] [diff] [review]
Patch v1.2

http://hg.mozilla.org/releases/comm-aurora/rev/3d9e603fc3bc
http://hg.mozilla.org/releases/comm-beta/rev/60e452381156