1152986 - Contact Last Name is repeated in Name field when viewing an attached vcard with Last Name and without Name fields

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Maria Angeles Oteo (:oteo)]

Attachment: 2015-04-09-23-22-49.png

STR:
1) Launch Contacts.
2) Create a contact without Name, but with Last Name fields (e.g. last Name= Oteo)
3) Launch Message app, create a message.
4) Add that contact as attachment.
5) Tap the attached contact and select view option


Actual Result:
Contact detail is shown (with form view) but name field is not empty, and last name is shown instead in that field. So name and last name fields are repeated (e.g. Name=Oteo, Last Name=Oteo). See file attached 

Expected Result: 
Contact detail should be shown (with form view) with Name field empty.

Note: If after reproducing the bug, the user closes the contact details form screen, pressing "X" button, and sends the message. The message is received correctly in the other device, without Name field.

In case user press "Done" button, "Duplicates founds" screen appears to give the user the option to merge the "Oteo Oteo" contact with the already included in the Agenda "Oteo" what it's really weird.

Note: this is a Contacts issue, the bug can be reproduced when receiving and trying to view a vcard file from Mail application with Last Name and without Name

Environmental variables:
flame master (3.0 version)
Build ID: 20150409064841
Gecko: 6febe17
Gaia: cdf5276
Platform version: 40.0a1

Environmental variables:
flame master (2.2 version)
Build ID: 20150409063108
Gecko: 980e301
Gaia: ea735c2
Platform version: 37.0

Comment 1

[Maria Angeles Oteo (:oteo)]

Adrian, could you have a look at it when you have time? Thanks a lot!

Comment 2

[Adrián de la Rosa]

I'm working on it!

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] ADLR-es:duplicate-name-vcard > mozilla-b2g:master

Comment 4

[Adrián de la Rosa]

Comment on attachment 8591790 [details] [review]
[gaia] ADLR-es:duplicate-name-vcard > mozilla-b2g:master

Minimal change, with no side effects as far as I know. All tests are green.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8591790 [details] [review]
[gaia] ADLR-es:duplicate-name-vcard > mozilla-b2g:master

Redirecting to sergi,since he owns sdcard code.

Comment 6

[Maria Angeles Oteo (:oteo)]

Francisco, this revision is taking longer, is Sergi still working on the project?
Perhaps we could have a look at the patch and rebase it, now we are merging the open vs import activities

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Agree, it's been a while without knowing from Sergi.

We can still merge it, so will reassign the review to myself.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1152986 > mozilla-b2g:master

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/3e450f495a2a72ffc89ff3e0485a087e8c0deae3

(had to create a new pr, since the previous one was done against a really old gaia)

Comment 10

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0, and the design of "View" screen is changed on the latest master build.

Actual results: Showing the ".vcf" contact name and "Import all" icon on the "View" screen , if you tap "Import all" icon, this contact in message will be merged with the contact saved in Contact app. The contact shows normally with last name in contact app,  which is not repeated in Name field.

See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150820150207
Gaia Revision          c6705f739fb605031eb2a0b943ba55c64bee5a03
Gaia Date              2015-08-20 14:36:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/095988abdc560bf8ba07a94a425c6922a3e9bfd6
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150820.183055
Firmware Date          Thu Aug 20 18:31:07 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150820204657
Gaia Revision          c6705f739fb605031eb2a0b943ba55c64bee5a03
Gaia Date              2015-08-20 14:36:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/095988abdc560bf8ba07a94a425c6922a3e9bfd6
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150820.200928
Firmware Date          Thu Aug 20 20:09:36 UTC 2015
Bootloader             s1

Comment 11

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.3gp