SpecialPowers.loadChromeScript needs sendSyncMessage

RESOLVED FIXED in Firefox 46

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed, firefox47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
In bug 1153126, we need a synchronous message to load mozinfo into mochitest.
(Assignee)

Comment 1

4 years ago
Created attachment 8590671 [details] [diff] [review]
specialpowers_sendSyncMessage.patch

I am going to set review flag after bug 852207 is fixed.
Depends on: 852207
Created attachment 8723403 [details]
MozReview Request: Bug 1153128 - Add sendSyncMessage to SpecialPowers.loadChromeScript. r=ted

Review commit: https://reviewboard.mozilla.org/r/36529/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36529/
Attachment #8723403 - Flags: review?(ted)
Comment on attachment 8590671 [details] [diff] [review]
specialpowers_sendSyncMessage.patch

This is very useful for making password manager tests works with e10s so I rebased the patch and fixed the expected return value in the test since we have an array of arrays.
Attachment #8590671 - Attachment is obsolete: true
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
(Assignee)

Comment 4

3 years ago
Matthew, thank you for reviving the patch!
Comment on attachment 8723403 [details]
MozReview Request: Bug 1153128 - Add sendSyncMessage to SpecialPowers.loadChromeScript. r=ted

https://reviewboard.mozilla.org/r/36529/#review34751

thanks for writing this and updating the tests.  This seems pretty safe.
Attachment #8723403 - Flags: review+

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c5338fae9902
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.