Closed Bug 1153128 Opened 6 years ago Closed 5 years ago

SpecialPowers.loadChromeScript needs sendSyncMessage

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

In bug 1153126, we need a synchronous message to load mozinfo into mochitest.
I am going to set review flag after bug 852207 is fixed.
Depends on: 852207
See Also: → 1251141
Comment on attachment 8590671 [details] [diff] [review]
specialpowers_sendSyncMessage.patch

This is very useful for making password manager tests works with e10s so I rebased the patch and fixed the expected return value in the test since we have an array of arrays.
Attachment #8590671 - Attachment is obsolete: true
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
Blocks: 1251151
Matthew, thank you for reviving the patch!
Comment on attachment 8723403 [details]
MozReview Request: Bug 1153128 - Add sendSyncMessage to SpecialPowers.loadChromeScript. r=ted

https://reviewboard.mozilla.org/r/36529/#review34751

thanks for writing this and updating the tests.  This seems pretty safe.
Attachment #8723403 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/c5338fae9902
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.