1153128 - SpecialPowers.loadChromeScript needs sendSyncMessage

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

In bug 1153126, we need a synchronous message to load mozinfo into mochitest.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: specialpowers_sendSyncMessage.patch

I am going to set review flag after bug 852207 is fixed.

Comment 2

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1153128 - Add sendSyncMessage to SpecialPowers.loadChromeScript. r=ted

Review commit: https://reviewboard.mozilla.org/r/36529/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36529/

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8590671 [details] [diff] [review]
specialpowers_sendSyncMessage.patch

This is very useful for making password manager tests works with e10s so I rebased the patch and fixed the expected return value in the test since we have an array of arrays.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Matthew, thank you for reviving the patch!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8723403 [details]
MozReview Request: Bug 1153128 - Add sendSyncMessage to SpecialPowers.loadChromeScript. r=ted

https://reviewboard.mozilla.org/r/36529/#review34751

thanks for writing this and updating the tests.  This seems pretty safe.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c5338fae9902

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c5338fae9902

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/67c621c0e0d9