Closed
Bug 852207
Opened 13 years ago
Closed 6 years ago
provide platform information (mozinfo) to tests in a nice format.
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: tbsaunde, Assigned: hiro)
References
Details
(Whiteboard: [mozbase])
Attachments
(1 file)
|
2.12 KB,
patch
|
ahal
:
review-
|
Details | Diff | Splinter Review |
currently when tests need to do things specific to one OS / OS version /debug or not people have to do anoying things like navigator.oscpu.startsWith("blah") which sucks, ted and jhammel think we could use mozinfo.json to make this nicer.
Updated•13 years ago
|
Summary: provide platform information to tests in a nice format. → provide platform information (mozinfo) to tests in a nice format.
Updated•13 years ago
|
Whiteboard: [mozbase]
Updated•13 years ago
|
Component: General → Mozbase
QA Contact: hskupin
Comment 1•13 years ago
|
||
Could you please explain this better?
Comment 2•13 years ago
|
||
I'm a bit unclear myself. We're trying to add useful data to mozinfo; what is to be added?
Comment 3•13 years ago
|
||
I guess the summary wasn't clear here, the proposal was to make mozinfo available to the *JavaScript* bits of our test harnesses, so that in a Mochitest you could simply say if (mozinfo.os == "windows") { ... }
We currently have mozinfo available in the xpcshell Python harness (but not the JS part), so maybe that'd be an easy first target?
| Assignee | ||
Comment 4•11 years ago
|
||
This patch output mozinfo as it is.
The output mozinfo does not completely match mozinfo.json in topobjdir because mozinfo.py updates its contents.
Assignee: nobody → hiikezoe
| Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8590667 [details] [diff] [review]
Output mozinfo into a file as is
Forgot to set review request.
Attachment #8590667 -
Flags: review?(ahalberstadt)
Comment 6•11 years ago
|
||
Comment on attachment 8590667 [details] [diff] [review]
Output mozinfo into a file as is
Review of attachment 8590667 [details] [diff] [review]:
-----------------------------------------------------------------
I don't think this patch is related to this bug. If there is a missing feature you need in mozinfo, could you file a new bug please? That being said, I don't think this is something we need. It's easy enough for consumers to dump mozinfo.info to a file on their own if they need to.
Attachment #8590667 -
Flags: review?(ahalberstadt) → review-
Comment 7•6 years ago
|
||
ahal: It seems that you fixed this in ?
changeset: 140196:a04093b3aaa4
user: Andrew Halberstadt <ahalberstadt@mozilla.com>
date: Fri Jul 26 14:40:04 2013 -0400
summary: Bug 865349 - Refactor B2G mochitests off automation.py and onto mozbase, r=jgriffin,ted
Flags: needinfo?(ahal)
Comment 8•6 years ago
|
||
Yeah, this hasn't been an issue for a long time :).
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(ahal)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•