1153224 - NSSBridge errors when trying to sync passwords

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Happens every time I sync manually.

E/GeckPasswordsProvider(25329): Error in NSSBridge
E/JavaBinder(25329): *** Uncaught remote exception!  (Exceptions are not yet supported across processes.)
E/JavaBinder(25329): java.lang.RuntimeException: java.lang.Exception: PK11SDR_Decrypt returned error 0: Success
E/JavaBinder(25329):
E/JavaBinder(25329):    at org.mozilla.gecko.db.PasswordsProvider.doCrypto(PasswordsProvider.java:247)
E/JavaBinder(25329):    at org.mozilla.gecko.db.PasswordsProvider.onPostQuery$3e5a7f14(PasswordsProvider.java:310)
E/JavaBinder(25329):    at org.mozilla.gecko.db.SQLiteBridgeContentProvider.query(SQLiteBridgeContentProvider.java:429)
E/JavaBinder(25329):    at android.content.ContentProvider.query(ContentProvider.java:966)
E/JavaBinder(25329):    at android.content.ContentProvider$Transport.query(ContentProvider.java:211)
E/JavaBinder(25329):    at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:112)
E/JavaBinder(25329):    at android.os.Binder.execTransact(Binder.java:446)
E/JavaBinder(25329): Caused by: java.lang.Exception: PK11SDR_Decrypt returned error 0: Success
E/JavaBinder(25329):
E/JavaBinder(25329):    at org.mozilla.gecko.NSSBridge.nativeDecrypt(Native Method)
E/JavaBinder(25329):    at org.mozilla.gecko.NSSBridge.decrypt(NSSBridge.java:44)
E/JavaBinder(25329):    at org.mozilla.gecko.db.PasswordsProvider.doCrypto(PasswordsProvider.java:242)
E/JavaBinder(25329):    ... 6 more

Comment 1

[:Margaret Leibovic]

This happens to me as well.

I should also note that a significant portion of my desktop passwords are not making their way to my Android device. I'm happy to help debug any busted records!

Comment 2

[Bill Maggs (bmaggs)]

Ditto. Passwords not currently syncing in Nightly, so I can't get a screenshot of the missing favicons.

Comment 3

[Richard Newman [:rnewman]]

/* Throws the current NSS error. */
static void
throwError(JNIEnv* jenv, const char * funcString) {
    char *msg;

    PRErrorCode perr = f_PR_GetError();
    char * errString = f_PR_ErrorToString(perr, 0);
    asprintf(&msg, "%s returned error %d: %s\n", funcString, perr, errString);


....


      rv = f_PK11SDR_Decrypt(&request, &reply, nullptr);
      if (rv != SECSuccess) {
        throwError(jenv, "PK11SDR_Decrypt");
        goto done;
      }


so f_PK11SDR_Decrypt is returning non-zero (SECSuccess is 0), but f_PR_GetError is zero.

A quick skim of pk11sdr.c doesn't suggest that it sets the PR error, so it looks like the NSSBridge error reporting code isn't entirely useful.

A good first step is to log the actual returned error code.

Comment 4

[:Grisha Kruglov]

I started to see this error consistently after triggering a sync. And for the first time ever.

Comment 5

[Richard Newman [:rnewman]]

(In reply to :Grisha Kruglov from comment #4)
> I started to see this error consistently after triggering a sync. And for
> the first time ever.

It's almost as if this whole system is built on twigs and drinking straws…

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.