Closed Bug 1153262 Opened 5 years ago Closed 5 years ago
Reading List Cache .js length comparison failure with new Readability/JSDOMParser changes
This happened when I tried to update Readability.js yesterday: https://treeherder.mozilla.org/logviewer.html#?job_id=2630764&repo=fx-team I'll investigate what changed.
Trypush for a fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b59a59ab407a looks green. :-)
Status: NEW → ASSIGNED
Comment on attachment 8590947 [details] [diff] [review] Remove length comparison from testReadingListCache, rs=gijs Approval Request Comment [Feature/regressing bug #]: Reader Mode. Today/yesterday's version of bug 1152022 broke this test, which is not so useful anymore now that we have much more thorough testing on the github repo, and also doesn't produce useful output to help debug what changed, so we're nuking a few lines in the test from orbit. [User impact if declined]: can't land bug 1152022 which will mean very low quality reader mode output [Describe test coverage new/current, TreeHerder]: this is a test-only change [Risks and why]: none, test-only change [String/UUID change made/needed]: nope
Comment on attachment 8590947 [details] [diff] [review] Remove length comparison from testReadingListCache, rs=gijs Should be in 38 beta 4.
You need to log in before you can comment on or make changes to this bug.