Closed Bug 1153262 Opened 5 years ago Closed 5 years ago

testReadingListCache.js length comparison failure with new Readability/JSDOMParser changes

Categories

(Firefox for Android :: Reader View, defect)

35 Branch
All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

This happened when I tried to update Readability.js yesterday:

https://treeherder.mozilla.org/logviewer.html#?job_id=2630764&repo=fx-team

I'll investigate what changed.
Comment on attachment 8590947 [details] [diff] [review]
Remove length comparison from testReadingListCache, rs=gijs

Approval Request Comment
[Feature/regressing bug #]: Reader Mode. Today/yesterday's version of bug 1152022 broke this test, which is not so useful anymore now that we have much more thorough testing on the github repo, and also doesn't produce useful output to help debug what changed, so we're nuking a few lines in the test from orbit.
[User impact if declined]: can't land bug 1152022 which will mean very low quality reader mode output
[Describe test coverage new/current, TreeHerder]: this is a test-only change
[Risks and why]: none, test-only change
[String/UUID change made/needed]: nope
Attachment #8590947 - Flags: approval-mozilla-beta?
Attachment #8590947 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/45927c53ea1d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment on attachment 8590947 [details] [diff] [review]
Remove length comparison from testReadingListCache, rs=gijs

Should be in 38 beta 4.
Attachment #8590947 - Flags: approval-mozilla-beta?
Attachment #8590947 - Flags: approval-mozilla-beta+
Attachment #8590947 - Flags: approval-mozilla-aurora?
Attachment #8590947 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.