1153262 - testReadingListCache.js length comparison failure with new Readability/JSDOMParser changes

Status: RESOLVED FIXED

(Firefox for Android :: Reader View, defect)

Description

[:Margaret Leibovic]

This happened when I tried to update Readability.js yesterday:

https://treeherder.mozilla.org/logviewer.html#?job_id=2630764&repo=fx-team

I'll investigate what changed.

Comment 1

[:Gijs (he/him)]

Trypush for a fix:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b59a59ab407a

looks green. :-)

Comment 2

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/45927c53ea1d

Comment 3

[:Gijs (he/him)]

Attachment: Remove length comparison from testReadingListCache, rs=gijs

Comment 4

[:Gijs (he/him)]

Comment on attachment 8590947 [details] [diff] [review]
Remove length comparison from testReadingListCache, rs=gijs

Approval Request Comment
[Feature/regressing bug #]: Reader Mode. Today/yesterday's version of bug 1152022 broke this test, which is not so useful anymore now that we have much more thorough testing on the github repo, and also doesn't produce useful output to help debug what changed, so we're nuking a few lines in the test from orbit.
[User impact if declined]: can't land bug 1152022 which will mean very low quality reader mode output
[Describe test coverage new/current, TreeHerder]: this is a test-only change
[Risks and why]: none, test-only change
[String/UUID change made/needed]: nope

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/45927c53ea1d

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8590947 [details] [diff] [review]
Remove length comparison from testReadingListCache, rs=gijs

Should be in 38 beta 4.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/09089c7cd48e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ffc047abd90