Closed
Bug 1153262
Opened 8 years ago
Closed 8 years ago
testReadingListCache.js length comparison failure with new Readability/JSDOMParser changes
Categories
(Firefox for Android Graveyard :: Reader View, defect)
Tracking
(firefox38 fixed, firefox39 fixed, firefox40 fixed)
RESOLVED
FIXED
Firefox 40
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
3.59 KB,
patch
|
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This happened when I tried to update Readability.js yesterday: https://treeherder.mozilla.org/logviewer.html#?job_id=2630764&repo=fx-team I'll investigate what changed.
Comment 1•8 years ago
|
||
Trypush for a fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b59a59ab407a looks green. :-)
Comment 2•8 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/45927c53ea1d
Status: NEW → ASSIGNED
Comment 3•8 years ago
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8590947 [details] [diff] [review] Remove length comparison from testReadingListCache, rs=gijs Approval Request Comment [Feature/regressing bug #]: Reader Mode. Today/yesterday's version of bug 1152022 broke this test, which is not so useful anymore now that we have much more thorough testing on the github repo, and also doesn't produce useful output to help debug what changed, so we're nuking a few lines in the test from orbit. [User impact if declined]: can't land bug 1152022 which will mean very low quality reader mode output [Describe test coverage new/current, TreeHerder]: this is a test-only change [Risks and why]: none, test-only change [String/UUID change made/needed]: nope
Attachment #8590947 -
Flags: approval-mozilla-beta?
Attachment #8590947 -
Flags: approval-mozilla-aurora?
Comment 5•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/45927c53ea1d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•8 years ago
|
status-firefox38:
--- → affected
status-firefox39:
--- → affected
Comment 6•8 years ago
|
||
Comment on attachment 8590947 [details] [diff] [review] Remove length comparison from testReadingListCache, rs=gijs Should be in 38 beta 4.
Attachment #8590947 -
Flags: approval-mozilla-beta?
Attachment #8590947 -
Flags: approval-mozilla-beta+
Attachment #8590947 -
Flags: approval-mozilla-aurora?
Attachment #8590947 -
Flags: approval-mozilla-aurora+
Comment 7•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/09089c7cd48e
Flags: in-testsuite+
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•