1153518 - [e10s] Location bar retains invisible selection and does not permit text drop

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Kestrel]

Steps:

e10s Nightly - now that drag and drop has been fixed (Bug 936092).
1. Highlight plain text in an e10s page.
2. Drag and drop into the location bar.
3. Attempt to repeat.

non-e10s Nightly, FF37, FF24
1. Enter text into the searchbar and highlight it.
2. Drag and drop into the location bar.
3. Attempt to repeat.

Actual results:

Dropping text into the location bar fails after either the first or second successful drop. The cursor shows a blocked symbol indicating drop is not possible. 

Expected results:

There should be no limit to how many times text can be dropped into the location bar. 


Only seems to happen for text dragged from the searchbar or an e10s page, text dragged from elsewhere works normally.

A second drop is sometimes allowed and seems to be for when the page has been visited previously.

Loading a new page resets the location bar and allows text to be dropped again. It can also be reset by dropping in a url and stopping before the page changes.

Comment 1

[Kestrel]

This is being caused by an invisible selection in the location bar which does not allow dropping text onto it.

Revised steps, focusing on e10s:

1. Make a partial selection inside location bar and remember its position.
2. Make a text selection within document and try to drag it into the location bar where the partial selection was made.
3. While still dragging, move the cursor across the now invisible partial selection and note how the cursor icon changes.

Expected results:

Should always be able to drop text anywhere in the location bar.

Actual results:

Dropping is not possible in selected parts of the location bar but it is not clear where, as any selection is only visible when the location bar has focus. 

This wasn't a problem with non-e10s because the location bar selection was not being retained like it is now.

Comment 2

[Neil Deakin]

Attachment: Potential fix

Comment 3

[Neil Deakin]

Attachment: Updated patch

Comment 4

[(no longer active)]

Comment on attachment 8621973 [details] [diff] [review]
Updated patch

Review of attachment 8621973 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please add a test case?  Thanks!

::: editor/libeditor/nsEditorEventListener.cpp
@@ +993,5 @@
> +  TabParent* tp = TabParent::GetFrom(sourceContent);
> +  if (tp) {
> +    return true;
> +  }
> +  

Nit: trailing whitespace.

Comment 5

[Neil Deakin]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #4)
> Comment on attachment 8621973 [details] [diff] [review]
> Updated patch
> 
> Review of attachment 8621973 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Can you please add a test case?  Thanks!
> 

We don't have a means of testing drag and drop between processes/applications.

Comment 6

[(no longer active)]

(In reply to Neil Deakin from comment #5)
> (In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from
> comment #4)
> > Comment on attachment 8621973 [details] [diff] [review]
> > Updated patch
> > 
> > Review of attachment 8621973 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Can you please add a test case?  Thanks!
> > 
> 
> We don't have a means of testing drag and drop between
> processes/applications.

Ugh, yeah, ok.

Comment 7

[Neil Deakin]

Attachment: For checkin

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please make sure the attached patch includes commit information when requesting checkin.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0467588b07fe

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0467588b07fe

Comment 11

[Andrei Vaida [:avaida]]

Reproduced the bug on Nightly 41.0a1 (2015-05-28) with e10s enabled, using the steps from Comment 0 & Comment 1.

This is verified fixed on Aurora 41.0a2 (2015-08-05) using Windows 10 x64 (10240), Ubuntu 14.04 (x86) and Mac OS X 10.9.5.