1153589 - Turn on containerless scrolling for root scroll frames on B2G

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

+++ This bug was initially created as a clone of Bug #1137890 +++

+++ This bug was initially created as a clone of Bug #1123921 +++

Try run in bug 1137890 shows that enabling containerless-root on B2G passes all tests. Local testing also showed no strange/broken behaviour, so I think we're good to turn it on.

Comment 1

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8591280 [details] [diff] [review]
Patch

Ship it!

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8591280 [details] [diff] [review]
Patch

My bad, I tested this more and realized it does actually break behaviour in the browser for some pages (e.g. people.mozilla.com/~kgupta/grid.html) when zoomed.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

The clipping change from bug 1147038 does fix half of the problem I was seeing, but the scrollbars are still mispositioned. Hopefully fixing bug 1133905 will take care of this.

Comment 4

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8591280 [details] [diff] [review]
Patch

This should be good now.

Comment 5

[Timothy Nikkel (:tnikkel)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a27f48c8fa1

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b769ef24faed

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b769ef24faed

Comment 8

[KTucker [:KTucker][Inactive 3/4/2016]]

This is causing a smoke test blocker. Please see bug 1166326. We may need this backed out.

Comment 9

[Timothy Nikkel (:tnikkel)]

Backed out in
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7e537fd67ec

The sheriff assured me this would make the next nightly.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cb3a97de6ee

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4cb3a97de6ee

Comment 12

[Sotaro Ikeda [:sotaro]]

This seems to cause the regression to youtube video app's video playback. When I scroll the youtube video app's list during video playback, video's rendering position is not correct.

Comment 13

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> This seems to cause the regression to youtube video app's video playback.
> When I scroll the youtube video app's list during video playback, video's
> rendering position is not correct.

I am going to check it by local back-out.

Comment 14

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> This seems to cause the regression to youtube video app's video playback.
> When I scroll the youtube video app's list during video playback, video's
> rendering position is not correct.

mstange said that bug 1148582 seems to fix it.

Comment 15

[Markus Stange [:mstange]]

This is the "clip not moving with async scroll" issue. I haven't checked which patches in bug 1148582 will actually fix it, I just know that we're expecting that bug to take care of all our clipping problems.

Comment 16

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #13)
> (In reply to Sotaro Ikeda [:sotaro] from comment #12)
> > This seems to cause the regression to youtube video app's video playback.
> > When I scroll the youtube video app's list during video playback, video's
> > rendering position is not correct.
> 
> I am going to check it by local back-out.

The local back-out fixed the problem.

Comment 17

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> This seems to cause the regression to youtube video app's video playback.
> When I scroll the youtube video app's list during video playback, video's
> rendering position is not correct.

kats, is it expected regression until bug 1148582 fix?

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Redirecting to tn, since he's the one actually working on this.

Comment 19

[KTucker [:KTucker][Inactive 3/4/2016]]

The landing for this is causing a smoke test blocker. Please see bug 1170611. We may need this backed out.

Comment 20

[Timothy Nikkel (:tnikkel)]

Backed out in
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0515cb0cb5a

Comment 21

[Timothy Nikkel (:tnikkel)]

(In reply to Markus Stange [:mstange] from comment #15)
> This is the "clip not moving with async scroll" issue. I haven't checked
> which patches in bug 1148582 will actually fix it, I just know that we're
> expecting that bug to take care of all our clipping problems.

It doesn't appear to be related to bug 1148582. There is only one actively scrolling scrollframe involved, and only one set of metrics.

Comment 22

[Markus Stange [:mstange]]

(In reply to Timothy Nikkel (:tn) from comment #21)
> There is only one actively
> scrolling scrollframe involved, and only one set of metrics.

But two clips: The video ImageLayer has its own overflow:hidden clip, and then there is the clip of the actively scrolling scrollframe - during scrolling, we want to move the overflow:hidden clip but not the clip that clips the video to the scrollframe.

Comment 23

[Timothy Nikkel (:tnikkel)]

Oh right, forgot about non-scrolling clips.

Comment 24

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc07aa95d2c9

Comment 25

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc07aa95d2c9