1153652 - Browser toolbar buttons reload, share, bookmark etc enable for urls with "about:" in them

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Sachin Irukula]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/600.5.17 (KHTML, like Gecko) Version/8.0.5 Safari/600.5.17

Steps to reproduce:

Start firefox/open new tab and take a look at browser toolbar when url is empty/like "about:"


Actual results:

Bookmark button, share button, reload button are enabled which are of no use and act different on changing the mode in home panel(while viewing reading list, bookmarks etc). 


Expected results:

All the buttons should be disable when the url is empty(contain "about:")

Comment 1

[Sachin Irukula]

Attachment: Patch for issue

Comment 2

[Brian Nicholson (:bnicholson)]

According to Darrin, we should not show the toolbar at all when we've opened a new tab with about:home. But if we come back to it later (by clicking back), we do want to show the toolbar so we can go forward again.

Comment 3

[Sachin Irukula]

But isn't a bit of inconsistent behavior showing toolbar for something and hiding it for others?

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8591373 [details] [review]
Patch for issue

Regardless of what we decide to do in the end, I think this PR is an improvement, so we should go ahead and land it. But let's put the controller logic in BrowserViewController instead of the toolbar as mentioned in the PR.

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8591373 [details] [review]
Patch for issue

Thanks for updating! Left more comments in the PR.

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8591373 [details] [review]
Patch for issue

Looks good, thanks!

Comment 7

[Darrin Henein [:darrin]]

Not to stop the party, but I'd like to keep this open until we have the desired behaviour as outlined in comment 2 (https://bugzilla.mozilla.org/show_bug.cgi?id=1153652#c2)... Or :bnicholson do you want to open and tracking? a follow up bug?

Comment 8

[Brian Nicholson (:bnicholson)]

(In reply to Darrin Henein [:darrin] from comment #7)
> Or :bnicholson do you want to open and tracking? a follow up bug?

Yep, filed bug 1161626.