1161626 - Don't show toolbar on first about:home load

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Brian Nicholson (:bnicholson)]

(From https://bugzilla.mozilla.org/show_bug.cgi?id=1153652#c2)
> According to Darrin, we should not show the toolbar at all when we've opened
> a new tab with about:home. But if we come back to it later (by clicking
> back), we do want to show the toolbar so we can go forward again.

Comment 1

[Wesley Johnston (:wesj)]

This involves some crazy state that I'd like to improve. We have this boolean homePanelIsInline flag that we set in some cases:

https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserViewController.swift#L337

It controls the layout of the "home" panel set of pages. i.e. are they shown above the bottom toolbar or over the top of it. When hitting "back" to return to about:home, I think we want to show the footer. Otherwise, it should be hidden.

TBH, just glancing at this code, I don't actually see that flag set anymore. Amazing ideas for how to do this better would be welcome.

Comment 2

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8614010 [details] [review]
Pull request

LGTM