Crash bp-1cc08a67-b7d3-4dfd-aaa8-4a4162150413 Steps to reproduce 1. Install ScrapBook X 1.12.0a46 https://addons.mozilla.org/en-US/firefox/addon/scrapbook-x/ 2. Alt > ScrapBook X > Capture Page 3. Alt > ScrapBook X > Choose the scrapped page 4. Click HTML editor toolbar button Actual Results Tab crashed
Created attachment 8595052 [details] [diff] [review] Patch v1 This does the trick. I added a long comment to point out some trickyness here.
Do you remember why the spellcheck engine constructor is sync? It seems like making it be async would be a simpler fix, if it's possible.
Created attachment 8595627 [details] [diff] [review] Patch v2 This works too. It's so much cleaner, as billm predicted.
Attachment #8595627 - Flags: review?(wmccloskey)
Attachment #8595627 - Flags: review?(wmccloskey) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
QA Whiteboard: [good first verify][verify in Nightly only]
User story was too helpful to reproduce the bug, did reproduce on nightly (40.0a1): Build ID 20150413030203 User Agent Mozilla/5.0 (Windows NT 6.1; rv:40.0) Gecko/20100101 Firefox/40.0 Latest nightly (42.0a1) has no crash while clicking on that HTML editor button Build ID 20150724030210 User Agent Mozilla/5.0 (Windows NT 6.1; rv:42.0) Gecko/20100101 Firefox/42.0 Same goes for latest beta (40.0) : Build ID 20150723165742 User Agent Mozilla/5.0 (Windows NT 6.1; rv:40.0) Gecko/20100101 Firefox/40.0 Tested from my 32 bit PC
You need to log in before you can comment on or make changes to this bug.