Closed
Bug 1153977
Opened 10 years ago
Closed 10 years ago
[e10s] Tab crashed when click HTML editor toolbar button of Scrapbook X
Categories
(Firefox :: Extension Compatibility, defect)
Tracking
()
RESOLVED
FIXED
Firefox 40
People
(Reporter: alice0775, Assigned: mrbkap)
References
Details
(Keywords: addon-compat, crash)
Crash Data
Attachments
(1 file, 1 obsolete file)
|
989 bytes,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Crash bp-1cc08a67-b7d3-4dfd-aaa8-4a4162150413
Steps to reproduce
1. Install ScrapBook X 1.12.0a46
https://addons.mozilla.org/en-US/firefox/addon/scrapbook-x/
2. Alt > ScrapBook X > Capture Page
3. Alt > ScrapBook X > Choose the scrapped page
4. Click HTML editor toolbar button
Actual Results
Tab crashed
|
||
Updated•10 years ago
|
|
Assignee | |
Comment 1•10 years ago
|
||
This does the trick. I added a long comment to point out some trickyness here.
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8595052 -
Flags: review?(wmccloskey)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mrbkap
Do you remember why the spellcheck engine constructor is sync? It seems like making it be async would be a simpler fix, if it's possible.
|
|
Assignee | |
Comment 4•10 years ago
|
||
This works too. It's so much cleaner, as billm predicted.
Attachment #8595052 -
Attachment is obsolete: true
Attachment #8595052 -
Flags: review?(wmccloskey)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8595627 -
Flags: review?(wmccloskey)
Attachment #8595627 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 6•10 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
|
||
Updated•10 years ago
|
QA Whiteboard: [good first verify][verify in Nightly only]
|
||
Comment 9•10 years ago
|
||
User story was too helpful to reproduce the bug, did reproduce on nightly (40.0a1):
Build ID 20150413030203
User Agent Mozilla/5.0 (Windows NT 6.1; rv:40.0) Gecko/20100101 Firefox/40.0
Latest nightly (42.0a1) has no crash while clicking on that HTML editor button
Build ID 20150724030210
User Agent Mozilla/5.0 (Windows NT 6.1; rv:42.0) Gecko/20100101 Firefox/42.0
Same goes for latest beta (40.0) :
Build ID 20150723165742
User Agent Mozilla/5.0 (Windows NT 6.1; rv:40.0) Gecko/20100101 Firefox/40.0
Tested from my 32 bit PC
You need to log in
before you can comment on or make changes to this bug.
Description
•