Closed Bug 1153977 Opened 9 years ago Closed 9 years ago

[e10s] Tab crashed when click HTML editor toolbar button of Scrapbook X

Categories

(Firefox :: Extension Compatibility, defect)

Product:
Firefox
Component:
Extension Compatibility
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Tracking Flags:
Tracking Status
e10s + ---
firefox40 --- fixed

People

(Reporter: alice0775, Assigned: mrbkap)

References

Details

(Keywords: addon-compat, crash)

Crash Data

Attachments

(1 file, 1 obsolete file)

Patch v2
989 bytes, patch
billm
: review+
Details | Diff | Splinter Review 
Crash bp-1cc08a67-b7d3-4dfd-aaa8-4a4162150413

Steps to reproduce
1. Install ScrapBook X 1.12.0a46 
    https://addons.mozilla.org/en-US/firefox/addon/scrapbook-x/ 
2. Alt > ScrapBook X > Capture Page
3. Alt > ScrapBook X > Choose the scrapped page
4. Click HTML editor toolbar button 

Actual Results
Tab crashed
Blocks: 1092216
Attached patch Patch v1 (obsolete) — — Splinter Review 
This does the trick. I added a long comment to point out some trickyness here.
Attachment #8595052 - Flags: review?(wmccloskey)
Assignee: nobody → mrbkap
Do you remember why the spellcheck engine constructor is sync? It seems like making it be async would be a simpler fix, if it's possible.
Attached patch Patch v2 — — Splinter Review 
This works too. It's so much cleaner, as billm predicted.
Attachment #8595052 - Attachment is obsolete: true
Attachment #8595052 - Flags: review?(wmccloskey)
Attachment #8595627 - Flags: review?(wmccloskey)
Attachment #8595627 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/c214d74afc78
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
QA Whiteboard: [good first verify][verify in Nightly only]
User story was too helpful to reproduce the bug, did reproduce on nightly (40.0a1):

Build ID 	20150413030203
User Agent 	Mozilla/5.0 (Windows NT 6.1; rv:40.0) Gecko/20100101 Firefox/40.0

Latest nightly (42.0a1) has no crash while clicking on that HTML editor button

Build ID 	20150724030210
User Agent 	Mozilla/5.0 (Windows NT 6.1; rv:42.0) Gecko/20100101 Firefox/42.0

Same goes for latest beta (40.0) :

Build ID 	20150723165742
User Agent 	Mozilla/5.0 (Windows NT 6.1; rv:40.0) Gecko/20100101 Firefox/40.0

Tested from my 32 bit PC
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: