Bug.get_bugs and Bug.get_history are missing from PUBLIC_METHODS (for backwards compatibility)

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
WebService
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Matt Tyson, Assigned: Matt Tyson)

Tracking

({regression})

unspecified
Bugzilla 4.0
regression
Bug Flags:
approval +
approval5.0 +
approval4.4 +
approval4.2 +
approval4.0 +

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
When the RPC whitelisting was introduced in bug 1090275, the get_bugs and get_history compatibility methods were not added to the RPC whitelist. 

This breaks the workaround introduced in bug 502807

We can either remove the old workarounds, or add them to the whitelist.

What's the preferred option?

I'm in favour of removing them. 5 years should be plenty of time to upgrade your scripts.

Comment 1

2 years ago
For 4.x, we must whitelist them, because it's not acceptable to break backward-compatibility on a stable branch. For 5.x, I agree they could simply go away.
Depends on: 1090275
Flags: blocking4.4.9?
Flags: blocking4.2.14?
Flags: blocking4.0.18?
Keywords: regression
Summary: Bug 1090275 breaks Bug.get_bugs backwards compatbility → Bug.get_bugs and Bug.get_history are missing from PUBLIC_METHODS (for backwards compatibility)
Target Milestone: --- → Bugzilla 4.0
(Assignee)

Comment 2

2 years ago
Created attachment 8591974 [details] [diff] [review]
4.2 and 4.0 patch

This will cleanly apply to 4.2 and 4.0
Attachment #8591974 - Flags: review?
(Assignee)

Comment 3

2 years ago
Created attachment 8591976 [details] [diff] [review]
Bugzilla 4.4

Patch for the 4.4 RPC API
Attachment #8591976 - Flags: review?(glob)

Comment 4

2 years ago
Comment on attachment 8591974 [details] [diff] [review]
4.2 and 4.0 patch

>     history
>+    get_history

get_history comes before history, alphabetically. r=LpSolit with this fix.
Attachment #8591974 - Attachment is patch: true
Attachment #8591974 - Flags: review? → review+

Comment 5

2 years ago
Comment on attachment 8591976 [details] [diff] [review]
Bugzilla 4.4

>     history
>+    get_history

Same comment here. r=LpSolit with get_history being before history.
Attachment #8591976 - Attachment is patch: true
Attachment #8591976 - Flags: review?(glob) → review+
(Assignee)

Comment 6

2 years ago
Created attachment 8591981 [details] [diff] [review]
Remove from Bugzilla 5.0 and HEAD

This patch applies to 5.0 and HEAD and removes the backwards compatibility methods.
Attachment #8591981 - Flags: review?(glob)
(Assignee)

Updated

2 years ago
Assignee: webservice → mtyson
Status: NEW → ASSIGNED

Comment 7

2 years ago
Comment on attachment 8591981 [details] [diff] [review]
Remove from Bugzilla 5.0 and HEAD

You forgot to fix POD in this file. Also, master also has code for it in ./API/1_0/Resource/Bug.pm.
Attachment #8591981 - Flags: review?(glob) → review-
(Assignee)

Comment 8

2 years ago
Created attachment 8591984 [details] [diff] [review]
Remove compatibility methods from 5.0

This will remove bugs.get_bugs and bugs.get_history from 5.0
Attachment #8591981 - Attachment is obsolete: true
Attachment #8591984 - Flags: review?(LpSolit)
(Assignee)

Comment 9

2 years ago
Created attachment 8591985 [details] [diff] [review]
Remove compatibility methods from master

This removes the methods from the master branch.
Attachment #8591985 - Flags: review?(LpSolit)

Comment 10

2 years ago
Comment on attachment 8591984 [details] [diff] [review]
Remove compatibility methods from 5.0

r=LpSolit
Attachment #8591984 - Flags: review?(LpSolit) → review+

Updated

2 years ago
Attachment #8591985 - Attachment is patch: true

Comment 11

2 years ago
Comment on attachment 8591985 [details] [diff] [review]
Remove compatibility methods from master

r=LpSolit
Attachment #8591985 - Flags: review?(LpSolit) → review+

Updated

2 years ago
Flags: approval?
Flags: approval5.0?
Flags: approval4.4?
Flags: approval4.2?
Flags: approval4.0?
Flags: blocking4.4.9?
Flags: blocking4.2.14?
Flags: blocking4.0.18?
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval4.4?
Flags: approval4.4+
Flags: approval4.2?
Flags: approval4.2+
Flags: approval4.0?
Flags: approval4.0+
Flags: approval+

Comment 12

2 years ago
I had to run dos2unix on some of your patches to remove CR line endings.

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   bdd9c47..056decf  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   d5c47c9..8a48cfd  5.0 -> 5.0

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   d445f63..b11abfe  4.4 -> 4.4

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   6bf9634..c955a24  4.2 -> 4.2

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   877ef5c..6bb6f95  4.0 -> 4.0
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 13

2 years ago
I updated the release notes for 5.0 to mention that the deprecated Bug.get_bugs and Bug.get_history methods are no longer supported:

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   056decf..13bd4ea  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   8a48cfd..e2a6126  5.0 -> 5.0

Comment 14

2 years ago
Fixes a problem in POD, caught by t/011pod.t:

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   c698db3..3f29df2  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   9333dc1..bfd649a  5.0 -> 5.0
You need to log in before you can comment on or make changes to this bug.