1154139 - Use cached collection keys in the routine case

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

We cache them, we have the info (same approach as for meta/global), but out of laziness we fetch keys every time.

Comment 1

[Nick Alexander :nalexander [he/him]]

Nah, we do good things here -- did you see that commit I pushed at you?

Comment 2

[Richard Newman [:rnewman]]

Yes. But even so, in HasMetaGlobal, we always fetch, right?

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/360

Hey hey, you already did most of this :0

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8595031 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/360

We talked about this: needs to check for timestamp changes and then key changes, and bail out if the keys changed.

Safe to assume default-only for now.

Comment 5

[Richard Newman [:rnewman]]

Stale PR:

https://github.com/mozilla/firefox-ios/pull/360

Comment 6

[Richard Newman [:rnewman]]

Attachment: Pull req.

I want at least two reviewers for this.

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8646563 [details] [review]
Pull req.

It's definitely safe in the success case, which is the only one we really care about just now.

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8646563 [details] [review]
Pull req.

This looks good. I don't see anything crazy in this code. But I have to rely on :nalexander for the big sync picture.

Comment 9

[Richard Newman [:rnewman]]

78a5f73