1154173 - Improve dom/base/test/test_domrequesthelper.xul

Status: RESOLVED DUPLICATE of bug 1154679

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

> ::: dom/base/test/test_domrequesthelper.xul
> @@ +47,2 @@
> >        is(dummy._messages, undefined, "Messages is undefined");
> > +      is_loosely(dummy._window, undefined, "Window is undefined");
> 
> is(..., null, ...) for these

I tried; I believe the property doesn't always exist when coming through here.

> I think you can remove the _messages test.  The only two hits for the string
> in this file are these two in this patch.  There are no hits for it in
> DOMRequestHelper.jsm.  It looks dead to me.  Get someone who's written this
> code to r= the reomval.
>
> @@ +63,2 @@
> >        is(dummy._messages, undefined, "Messages is undefined");
> > +      is_loosely(dummy._window, undefined, "Window is undefined");
> 
> is(..., null, ...) for these
>
> @@ +387,5 @@
> >          var req_ = dummy.getRequest(id);
> >          is(req, req_, "Got correct request");
> >          dummy.removeRequest(id);
> >          req = dummy.getRequest(id);
> > +        is(req, undefined, "No request");
> 
> Any chance you could make a followup or something to make this check for
> null, after making DOMRequestHelper.jsm explicitly return null rather than
> fall off the end of its function?


(or remove DOMRequest).