1154235 - Merge BluetoothUtils.{cpp,h} variants into single file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1154235: Use |BroadcastSystemMessage| in |BluetoothService::Notify|

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1154235: Move dom/bluetooth/bluetooth2/BluetoothUtils.{cpp,h} to /dom/bluetooth

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1154235: Share BluetoothUtils.{cpp,h} between Bluetooth v1 and v2

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1154235: Use |snprintf| in Bluetooth utililities

Comment 5

[Ben Tian (inactive)]

Comment on attachment 8592176 [details] [diff] [review]
[04] Bug 1154235: Use |snprintf| in Bluetooth utililities

Review of attachment 8592176 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 6

[Ben Tian (inactive)]

Comment on attachment 8592175 [details] [diff] [review]
[03] Bug 1154235: Share BluetoothUtils.{cpp,h} between Bluetooth v1 and v2

Review of attachment 8592175 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 7

[Ben Tian (inactive)]

Comment on attachment 8592171 [details] [diff] [review]
[01] Bug 1154235: Use |BroadcastSystemMessage| in |BluetoothService::Notify|

Review of attachment 8592171 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2742c3375cb

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1154235: Share BluetoothUtils.{cpp,h} between Bluetooth v1 and v2 (v2)

Changes since v1:

  - touched CLOBBER to regenerate file dependencies

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks Ben!

https://hg.mozilla.org/integration/b2g-inbound/rev/d158ea5f1d25
https://hg.mozilla.org/integration/b2g-inbound/rev/b819c32ebb30
https://hg.mozilla.org/integration/b2g-inbound/rev/ed90daa45297
https://hg.mozilla.org/integration/b2g-inbound/rev/ef3c3dba06b9

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=ef3c3dba06b9

Comment 11

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/d158ea5f1d25
https://hg.mozilla.org/mozilla-central/rev/b819c32ebb30
https://hg.mozilla.org/mozilla-central/rev/ed90daa45297
https://hg.mozilla.org/mozilla-central/rev/ef3c3dba06b9