1154268 - Fetch Request should not allow creating a GET request with a body by copying a PUT request

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

The Fetch spec had a bug that let a GET Request with a body be created from a PUT request.  See:

  https://github.com/whatwg/fetch/issues/44

We should catch up with the fix to prevent this.  The Cache spec is currently written under the assumption that a GET Request can never have a body.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Fetch Request should not allow creating a GET request with a body by copying a PUT request

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8605554 [details] [diff] [review]
Fetch Request should not allow creating a GET request with a body by copying a PUT request

Review of attachment 8605554 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +2374,5 @@
>  bool
>  PaintedLayerData::CanOptimizeToImageLayer(nsDisplayListBuilder* aBuilder)
>  {
>    if (!mImage) {
> +    return false;

This seems unrelated?

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6cb759cdb9ae

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6cb759cdb9ae