Closed Bug 1154268 Opened 8 years ago Closed 8 years ago

Fetch Request should not allow creating a GET request with a body by copying a PUT request

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: bkelly, Assigned: nsm)

References

Details

Attachments

(1 file)

The Fetch spec had a bug that let a GET Request with a body be created from a PUT request.  See:

  https://github.com/whatwg/fetch/issues/44

We should catch up with the fix to prevent this.  The Cache spec is currently written under the assumption that a GET Request can never have a body.
Assignee: nobody → nsm.nikhil
Comment on attachment 8605554 [details] [diff] [review]
Fetch Request should not allow creating a GET request with a body by copying a PUT request

Review of attachment 8605554 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +2374,5 @@
>  bool
>  PaintedLayerData::CanOptimizeToImageLayer(nsDisplayListBuilder* aBuilder)
>  {
>    if (!mImage) {
> +    return false;

This seems unrelated?
Attachment #8605554 - Flags: review?(bkelly) → review+
https://hg.mozilla.org/mozilla-central/rev/6cb759cdb9ae
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.