115447 - Tooltip allignment is wrong in custom themes

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[James Ross]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6+)
Gecko/20011211
BuildID:    2001121103

Every single tooltip is coming up with it's top and left the same as the mouse
pointer - rather than offset (either down, or to the side). This causes the
tooltip to vanish when it realise the mouse is not over the original item any more.

And, to wrap things up, the original item loses any hover-hiliting, etc, when
the tooltip comes up, and does not regain it when the tooltip vanishes.

I'm not sure I've got the right component... but this does affect all tooltips
in the entire Mozilla distribution.

Reproducible: Always
Steps to Reproduce:
1. Hover mouse over any item that has a tooltip.


Actual Results:  Tooltips appear, as expected, but not offset from the mouse.
They then disappear very quickly, leaving the item without and hover-hiliting.

Expected Results:  Tooltil appears offset from the mouse.

Comment 1

[John Morrison]

I don't see this at all, in a current trunk build (2am today) on win32.

Comment 2

[James Ross]

Ok, I think the problem is that some fool in the XP Toolkit area has changed the
requirements of themes *again*. The mis-allignment only happens on
non-pre-installed themes (i.e. it works on Modern and Classic, but that's it).

It is therefore still a bug, since Mozilla should provide a reasonable *default*
for themes that don't know they have to provided it (god only knows where).

(bear in mind that I get *very* anoyed when something changes that *breaks*
perfectly good and working themes... /me looks supiciously at bug 113009)

Comment 3

[James Ross]

Oh yeah, it was working about 2 weeks ago, as well. So it was a *recent* change.

Comment 4

[Brendan Eich [:brendan]]

I believe the reporter, despite his abusive word choice.  Hewitt, can you have a
look?  We shouldn't be abusing 3rd party themes across a milestone boundary in
this way, I think.

/be

Comment 5

[Joe Hewitt (gone)]

I'm aware of this problem, it will be fixed when I fix 113009.

*** This bug has been marked as a duplicate of 113009 ***

Comment 6

[James Ross]

I don't think this bug is a dup of 113009 (otherwise I wouldn't have filed it in
the first place) - 113009 is about moving the location on the tooltip offset,
not about what's broken the themes. According to the status of bug 113009,
nothing has been changed yet, and so can't have caused this bug - so something
else is resposible for breaking the themes.

Therefore, I would like this bug reopened for dealing with *how/why* the themes
were broken, and fixing them irrespective of move the internal storage location
of the tooltip offset.

Comment 7

[Joe Hewitt (gone)]

The themes were broken because I moved the hardcoded 21 pixel tooltip y offset
from C++ into CSS.  To fix your theme, just put this into global/popup.css

tooltip {
  margin-top: 21px;
}

But, the best way to do this is to offset the tooltip by the height of the
cursor, in an OS-dependent way (nsLookAndFeel), which is the point of bug
113009.  Please don't re-open this bug, just fix your theme.

Comment 8

[Brendan Eich [:brendan]]

Hewitt, who is gonna read your final comment in this resolved-dup bug.  Am I
missing other, more conspicuous notification?  Sorry if so; adding relnote keyword.

/be

Comment 9

[James Ross]

I'm with Brendan on this - we need to either put in a default (and leave this
bug open until it's there), or make it *really* clear that this is something
theme developers need to know about.

BTW Joe, if I was writing a theme, I'd quite happily put in the extra CSS line,
and tell people they need to update to the latest version. However, I'm using
themes, and the lack of a default has basically turned Mozilla into a
no-tooltips program. Which just isn't good enough. Hence this bug - which I'm
now reopening.

Comment 10

[Joe Hewitt (gone)]

Ok, I'll put the default into xul.css for now.

Comment 11

[Joe Hewitt (gone)]

Attachment: patch

Comment 12

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.7

Comment 13

[Joe Hewitt (gone)]

fixed on trunk and branch