Closed Bug 1154615 Opened 5 years ago Closed 5 years ago

Rename AnimationPlayer to Animation

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

(Keywords: dev-doc-needed)

Attachments

(9 files)

Now that the existing Animation class has been renamed (bug 1152171) we can rename AnimationPlayer to Animation. This is the big one. We should do a minimal patch that just updates the WebIDL and does as little else as possible so as not to burden whichever DOM peer gets lumped with the review.

Then we can pick off all the other usages of "player" bit by bit and update them.
Jonathan, I'm not going to touch this for at least a day or two, maybe not even until next week, so feel free to take it if you're interested in doing it.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
This patch is a fairly minimal rename of the AnimationPlayer interface. It
leaves a bunch of local variables and helper classes still using the word
"player". These will be addressed in subsequent patches that don't require DOM
peer review.
Attachment #8594595 - Flags: review?(bugs)
This patch also updates the method names on PendingAnimationTracker but leaves
a number of local variables which will be fixed in a subsequent patch.
Attachment #8594596 - Flags: review?(jwatt)
This patch does not, however,  update references to
AnimationPlayerCollection/CSSTransitionPlayer etc. which we will fix when we get
to layout/style.
Attachment #8594598 - Flags: review?(jwatt)
We will rename CSSAnimationPlayer/CSSTransitionPlayer in a separate patch
Attachment #8594600 - Flags: review?(jwatt)
Attachment #8594603 - Flags: review?(jwatt)
Comment on attachment 8594595 [details] [diff] [review]
part 1 - Rename AnimationPlayer to Animation in WebIDL

I hope "Animation" in the global scope isn't common enough word in web pages that this breaks something.
Attachment #8594595 - Flags: review?(bugs) → review+
Attachment #8594596 - Flags: review?(jwatt) → review+
Attachment #8594597 - Flags: review?(jwatt) → review+
Attachment #8594598 - Flags: review?(jwatt) → review+
Attachment #8594599 - Flags: review?(jwatt) → review+
Attachment #8594600 - Flags: review?(jwatt) → review+
Attachment #8594601 - Flags: review?(jwatt) → review+
Attachment #8594602 - Flags: review?(jwatt) → review+
Attachment #8594603 - Flags: review?(jwatt) → review+
(In reply to Olli Pettay [:smaug] from comment #12)
> I hope "Animation" in the global scope isn't common enough word in web pages
> that this breaks something.

Yes, we don't know yet. Chrome is exposing 'Animation' in the global scope in canary builds and don't appear to have hit anything yet so fingers crossed we're ok.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.