1154615 - Rename AnimationPlayer to Animation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Now that the existing Animation class has been renamed (bug 1152171) we can rename AnimationPlayer to Animation. This is the big one. We should do a minimal patch that just updates the WebIDL and does as little else as possible so as not to burden whichever DOM peer gets lumped with the review.

Then we can pick off all the other usages of "player" bit by bit and update them.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Jonathan, I'm not going to touch this for at least a day or two, maybe not even until next week, so feel free to take it if you're interested in doing it.

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 1 - Rename AnimationPlayer to Animation in WebIDL

This patch is a fairly minimal rename of the AnimationPlayer interface. It
leaves a bunch of local variables and helper classes still using the word
"player". These will be addressed in subsequent patches that don't require DOM
peer review.

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 2 - Rename PendingPlayerTracker to PendingAnimationTracker

This patch also updates the method names on PendingAnimationTracker but leaves
a number of local variables which will be fixed in a subsequent patch.

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 3 - Rename internal members of PendingAnimationTracker

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 4 - Rename references to players in dom/animation

This patch does not, however,  update references to
AnimationPlayerCollection/CSSTransitionPlayer etc. which we will fix when we get
to layout/style.

Comment 6

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 5 - Rename AnimationPlayerCollection to AnimationCollection

Comment 7

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 6 - Rename references to players within layout/

We will rename CSSAnimationPlayer/CSSTransitionPlayer in a separate patch

Comment 8

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 7 - Rename CSSAnimationPlayer and CSSTransitionPlayer

Comment 9

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 8 - Rename references to players in animation observers

Comment 10

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: part 9 - Rename test files

Comment 11

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a5ac6b9c20a

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8594595 [details] [diff] [review]
part 1 - Rename AnimationPlayer to Animation in WebIDL

I hope "Animation" in the global scope isn't common enough word in web pages that this breaks something.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7428dd3f948
https://hg.mozilla.org/integration/mozilla-inbound/rev/12c02905de55
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d4113af5140
https://hg.mozilla.org/integration/mozilla-inbound/rev/675592491434
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bb61d7addb3
https://hg.mozilla.org/integration/mozilla-inbound/rev/023fdd5ebd3f
https://hg.mozilla.org/integration/mozilla-inbound/rev/1649585af78e
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2622dba8a8
https://hg.mozilla.org/integration/mozilla-inbound/rev/88a7dbe87754

Comment 14

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Olli Pettay [:smaug] from comment #12)
> I hope "Animation" in the global scope isn't common enough word in web pages
> that this breaks something.

Yes, we don't know yet. Chrome is exposing 'Animation' in the global scope in canary builds and don't appear to have hit anything yet so fingers crossed we're ok.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7428dd3f948
https://hg.mozilla.org/mozilla-central/rev/12c02905de55
https://hg.mozilla.org/mozilla-central/rev/7d4113af5140
https://hg.mozilla.org/mozilla-central/rev/675592491434
https://hg.mozilla.org/mozilla-central/rev/2bb61d7addb3
https://hg.mozilla.org/mozilla-central/rev/023fdd5ebd3f
https://hg.mozilla.org/mozilla-central/rev/1649585af78e
https://hg.mozilla.org/mozilla-central/rev/9e2622dba8a8
https://hg.mozilla.org/mozilla-central/rev/88a7dbe87754