1154634 - [RTL][Dialer] The "Call ended" string is truncated and shows ellipsis

Status: RESOLVED DUPLICATE of bug 1155901

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Sue]

Attachment: call_ended.png

[1.Description]:
[l10n][v2.2][Dialer]Arabic: End the call from another device, you will find the "Call ended" string in call banner at top of homescreen is truncate.
See attachment:call_ended.png

[2.Testing Steps]: 
Prerequisite: Set system language as Arabic and insert a valid SIM card.
1. MT a call from another device. 
2. The test phone should accept the call and then tap the "Home" button. 
3. Look at the call banner at the top of the homescreen. 
4. End the call. Check the "Call ended" string.

[3.Expected Result]: 
4. The string is translated properly without truncation. 

[4.Actual Result]: 
4. The "Call ended" string is truncate.

[5.Reproduction build]: 
Device: Flame 2.2 (affected)
Build ID               20150414162502
Gaia Revision          16e948bfaaa15dbc0200135d52f16257b4eab193
Gaia Date              2015-04-14 21:08:25
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0eec28e78eb1
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.201749
Firmware Date          Tue Apr 14 20:17:58 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 2.1 user (unaffected)
Build ID               20150414161204
Gaia Revision          bbe983b4e8bebfec26b3726b79568a22d667223c
Gaia Date              2015-04-09 13:52:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/3e3cbe35bce3
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.194039
Firmware Date          Tue Apr 14 19:40:50 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
12223

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

This seems like a regression from 2.1. so nominating

Also, changing the component as this isn't an l10n bug (if the same string fits in 2.1 and not in 2.2, that isn't an l10n issue)

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

I'm actually not sure if we can consider this as a regression since RTL was not fully implemented in 2.1. Please feel free to correct. thanks

Comment 3

[Dylan Oliver [:doliver]]

It looks like it barely fit on 2.1 so it may still be worth trying a different string in l10n to be safer. Also, the screen shots here appear to be a US phone number -- we should ensure to have enough space to display a full number in the likely Arabic target markets. 

Tamara, are you aware of any changes to the call status banner that would have altered the spacing here? Or if this is system functionality can you update the component?

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

In the meantime, flagging Rami so he can advise about the string size

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage:
we feel it's appropriate to let the engineering team do work around at this moment.
i believe this issue happens not only in Arabic. Very likely Russian locale has the same issue.

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Let's put this in backlog and get it fixed on master.
Firstly, we'll need input from VD/UX to handle situation like this.

Comment 7

[Gabriele Svelto [:gsvelto]]

Most likely an effect of the changes I made in bug 1142485.

Comment 8

[Tamara Hills [:thills]]

Clearing ni as per Comment 7

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Ok so this is clearly a recent regression. Why aren't we blocking on 2.2 then?

Comment 10

[Carol Huang [:Carol]]

I think it might related to the system notification.

Hi Eric,
Could you help take a look at this?
Let me know if you need any help from me, thanks!!

Comment 11

[Gabriele Svelto [:gsvelto]]

(In reply to Carol Huang [:Carol] from comment #10)
> I think it might related to the system notification.

This is a callscreen problem and I'll address it right after I'm done with bug 1155901 by making the string auto-resize.

Comment 12

[Eric Pang [:epang] UX]

(In reply to Gabriele Svelto [:gsvelto] from comment #11)
> (In reply to Carol Huang [:Carol] from comment #10)
> > I think it might related to the system notification.
> 
> This is a callscreen problem and I'll address it right after I'm done with
> bug 1155901 by making the string auto-resize.

Gabriele, auto resizing the string works for me as long as it's not too small.  Also can check that all elements are vertically center aligned with the icon and number?

Please flag me for ui-review when ready, thanks!

Comment 13

[Gabriele Svelto [:gsvelto]]

(In reply to Eric Pang [:epang] from comment #12)
> Gabriele, auto resizing the string works for me as long as it's not too
> small.

Yes, a minimum font size can be specified. What do you think would be suitable here?

> Also can check that all elements are vertically center aligned with
> the icon and number?
> 
> Please flag me for ui-review when ready, thanks!

Sure, will do.

Comment 14

[Rami Khader]

Sorry the late reply, I found the the font size for the call end is big maybe smaller by one or two will be better since it is just notification for the call end

Comment 15

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:

This was dropped although it was a regression. Since we're past CC for 2.2, nominating this for 3.0 - in the case that this still is relevant in the upcoming release

Comment 16

[Gabriele Svelto [:gsvelto]]

(In reply to Delphine Lebédel [:delphine - use need info] from comment #15)
> This was dropped although it was a regression. Since we're past CC for 2.2,
> nominating this for 3.0 - in the case that this still is relevant in the
> upcoming release

I'm sorry this didn't go into v2.2 but the change is non-trivial and I ended up working on it too close to the CC date to risk landing it.

Comment 17

[Johan Lorenzo [:jlorenzo]]

Comms triage: Is it okay to reduce the font size, or is the truncation fine here?

Comment 18

[Harly Hsu[:harly]]

Just as Eric has replied in Comment 12, UX are fine with reducing the font size as long as it is readable. Truncation isn't a good experience in this use case. But please flag me or Eric for ui-review once there is a patch. Thanks.

Comment 19

[Gabriele Svelto [:gsvelto]]

I've got a patch undergoing review in bug 1155901 which dynamically resizes the string to fit the available space. I've tested it across a dozen different languages both LTR and RTL and it seems to be working well.

Comment 20

[Johan Lorenzo [:jlorenzo]]

Comms triage: Based on comment 19. Verify me once bug 1155901 lands.