Closed
Bug 1154739
Opened 10 years ago
Closed 10 years ago
On Desktop, only enable APZ for E10S windows
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla40
People
(Reporter: dvander, Assigned: kats)
References
Details
Attachments
(2 files, 1 obsolete file)
4.46 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
5.04 KB,
patch
|
dvander
:
review+
mstange
:
review+
|
Details | Diff | Splinter Review |
None of the Desktop platforms receive input off the main thread, so they effectively require E10S. That may change for some platforms, but not right now.
Updated•10 years ago
|
tracking-e10s:
--- → -
Reporter | ||
Comment 1•10 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e944fc5e8702
If this sticks I'll follow up with a backout after the next m-c merge.
Reporter | ||
Comment 2•10 years ago
|
||
Reporter | ||
Comment 3•10 years ago
|
||
(And do a m.d.platform post)
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Updated•10 years ago
|
Blocks: apz-windows
Assignee | ||
Updated•10 years ago
|
Assignee: dvander → bugmail.mozilla
Summary: On Desktop, only enable APZ for E10S → On Desktop, only enable APZ for E10S windows
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
I need to test these patches on all platforms still.
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8596764 -
Attachment is obsolete: true
Attachment #8597256 -
Flags: review?(mstange)
Attachment #8597256 -
Flags: review?(dvander)
Assignee | ||
Updated•10 years ago
|
Attachment #8596761 -
Flags: review?(wmccloskey)
Assignee | ||
Comment 7•10 years ago
|
||
I tested this on OSX, Linux, and Windows, with e10s enabled and disabled by default, using "open new e10s window" and "open new non-e10s window". Works as intended (i.e. APZ enabled in all e10s windows but not otherwise).
Reporter | ||
Updated•10 years ago
|
Attachment #8597256 -
Flags: review?(dvander) → review+
Updated•10 years ago
|
Attachment #8597256 -
Flags: review?(mstange) → review+
Comment 8•10 years ago
|
||
Comparing the dxr search results of "electrolysis" and "e10s" seems to indicate that e10s is the preferred name.
Assignee | ||
Comment 9•10 years ago
|
||
I'm always unsure how to camelcase e10s :)
Comment hidden (offtopic) |
Comment on attachment 8596761 [details] [diff] [review]
Part 1 - Rename a flag
Review of attachment 8596761 [details] [diff] [review]:
-----------------------------------------------------------------
Let's call it mMultiProcessWindow. We use gMultiProcessBrowser for similar things in the frontend. Also, I don't like to use codenames in source code.
Attachment #8596761 -
Flags: review?(wmccloskey) → review+
Comment 12•10 years ago
|
||
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/666f287e0dab
https://hg.mozilla.org/mozilla-central/rev/91110ad64d32
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 14•10 years ago
|
||
I am really doubt about decision of this bug.
Why it was needed? As result we have bug 1162009.
You need to log in
before you can comment on or make changes to this bug.
Description
•