1154799 - "this._browser.messageManager is undefined" error just by starting Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[:aceman]

I started to see this error recently:
Error: TypeError: this._browser.messageManager is undefined
Source File: chrome://global/content/bindings/findbar.xml
Line: 272

It shows just by starting Thunderbird. Other than that I see no ill effects and also the findbar in compose window seems to work.

Possible cause is bug 1133981. Does this reference to "this._browser.messageManager" also need a guard whether this._browser.messageManager actually exists? Like the other occurrences do?

Comment 1

[:Gijs (he/him)]

I don't understand how we can have a messageManager-less browser. Mike?

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1154799_messageManager_undefined.patch

Need to rebuild to test, but this would be my guess.

Comment 3

[Magnus Melin [:mkmelin]]

Seems to work.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8592942 [details] [diff] [review]
bug1154799_messageManager_undefined.patch

Thanks!

Comment 6

[Philip Chee]

You might also want this bit:
http://hg.mozilla.org/mozilla-central/rev/c4950a780504#l2.31

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: bug1154799_messageManager_undefined.patch

Add the contentWindowAsCPOW property too.

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8593770 [details] [diff] [review]
bug1154799_messageManager_undefined.patch

I don't see any current usage for contentWindowAsCPOW (except maybe in toolkit/components/printing/, but I don't think we support printing IM conversations), but it won't hurt and can hopefully avoid future bustages if it gets used more widely.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

(In reply to :Gijs Kruitbosch from comment #1)
> I don't understand how we can have a messageManager-less browser. Mike?

Looks like convbrowser.xml implements its own browser binding that does not have messageManager.

Comment 10

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/3be28f0d0286

Comment 11

[Philip Chee]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #9)
> (In reply to :Gijs Kruitbosch from comment #1)
> > I don't understand how we can have a messageManager-less browser. Mike?
> 
> Looks like convbrowser.xml implements its own browser binding that does not
> have messageManager.
Can't convbrowser.xml inherit/extends browser.xml?

Comment 12

[Florian Quèze [:florian]]

(In reply to Philip Chee from comment #11)

> Can't convbrowser.xml inherit/extends browser.xml?

Maybe. We actually wondered the same thing in #instantbird a few days ago. This fork was made 8 years ago, I don't remember the reason for it unfortunately.