Closed Bug 1155016 Opened 5 years ago Closed 4 years ago

Autophone - refresh quitter.xpi from mozilla-central build

Categories

(Testing :: Autophone, defect)

defect
Not set

Tracking

(firefox40 affected)

RESOLVED FIXED
Tracking Status
firefox40 --- affected

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(2 files)

bug 641829 added quitter@mozilla.org.xpi to the output of builds from source. This version of quitter differs from the modified original version of quitter I have been using in Autophone in that it:

1. restricts the min/max version of the build to that of the build.

2. changes the invocation so that you no longer send an event to initiate the quit, but call Quitter.quit()

It does appear to work with the appropriate build of Firefox for Android though.

To make the saved version of quitter.xpi less of a mystery blob, I can refresh the version in Autophone and change the pages which invoke quitter to use the new Quitter.quit() call.

I will have to make a change to the min/max versions of the version saved in Autophone in order to use this across multiple branches. The old version of Jesse's quitter has worked unchanged for a number of years (since Firefox version 2 iirc), but it appears this new version requires the ability to handle messages and load content script and I'm not sure of the proper minimum version.

Snorp: If I follow this approach, will it meet your needs?

Ted: Do you think it would be worthwhile to change the min version specified in the tools/quitter/install.rdf to be the actual minimum version required rather than the version of the build from which it was created? 

Does anyone have any opinions for or against the approach I've outlined?
(In reply to Bob Clary [:bc:] from comment #0)
> Ted: Do you think it would be worthwhile to change the min version specified
> in the tools/quitter/install.rdf to be the actual minimum version required
> rather than the version of the build from which it was created? 

That should be fine. It's only using the exact build version because I was lazy and didn't care about it working in anything but the build it was made with.
Depends on: 1159475
Changes the inline calls to the original quitter with a reference to a script living in Autophone which will call the quit method.
Attachment #8732142 - Flags: review?(jmaher)
This replaces the original quitter with a signed, modified version of the in-tree version of quitter@mozilla.org. The autophone version has modified names, uuids and paths so that there is no chance it will conflict with the standard in-tree version in the event that both are installed.

The additional script files/base/quitter.js detects whether the Autophone version or the standard version are installed and uses the appropriate version. This should allow developer's to use either Autophone's version or the in-tree version transparently.

I've been running tests with s1s2:

https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&filter-searchStr=autophone&exclusion_profile=false&filter-tier=1&filter-tier=2&filter-tier=3&fromchange=cd6d52ddb575&tochange=21031b1de161

https://treeherder.allizom.org/#/jobs?repo=mozilla-aurora&filter-searchStr=autophone&exclusion_profile=false&filter-tier=1&filter-tier=2&filter-tier=3&fromchange=ee1c8ed1e4b6&tochange=5a5f9c53b6aa

https://treeherder.allizom.org/#/jobs?repo=mozilla-beta&filter-searchStr=autophone&exclusion_profile=false&filter-tier=1&filter-tier=2&filter-tier=3&fromchange=4d07b9c0fcc9&tochange=64a15a51bc39

https://treeherder.allizom.org/#/jobs?repo=mozilla-release&filter-searchStr=autophone&exclusion_profile=false&filter-tier=1&filter-tier=2&filter-tier=3&fromchange=08856396ce2f&tochange=3aabff692e7b

The final test will be a short Mdm run, but this is looking good so far.
Attachment #8732145 - Flags: review?(jmaher)
Attachment #8732142 - Flags: review?(jmaher) → review+
Attachment #8732145 - Flags: review?(jmaher) → review+
https://github.com/mozilla/autophone/commit/85f9ccdcd7db4602d229d218dfb9f9d3482e90ad

deployed 2016-03-19 05:30 PT
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.