1155055 - Unnecessary return in tabScrolling property in toolkit/content/widgets/autocomplete.xml.

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Tooru Fujisawa [:arai]]

https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/autocomplete.xml#306
>       <property name="tabScrolling"
>                 onset="return this.setAttribute('tabscrolling', val); return val;"
>                 onget="return this.getAttribute('tabscrolling') == 'true';"/>

onset returns the value returned from setAttribute, which is void.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Remove unnecessary return in tabScrolling property in toolkit/content/widgets/autocomplete.xml.

Removed first `return`.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b505498f5db

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad8fc5dffc9c

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ad8fc5dffc9c