1160770 - Unnecessary return in tabScrolling property in XPFE autocomplete.xml.

Status: RESOLVED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[Philip Chee]

Sat May 02 2015 21:51:07
Warning: SyntaxError: unreachable code after return statement
Source file: chrome://global/content/autocomplete.xml
Line: 279, Column: 47
Source code:
return this.setAttribute('tabscrolling', val); return val;

(From Bug 1155055 comment #0)
> https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/
> autocomplete.xml#306
> >       <property name="tabScrolling"
> >                 onset="return this.setAttribute('tabscrolling', val); return val;"
> >                 onget="return this.getAttribute('tabscrolling') == 'true';"/>
> 
> onset returns the value returned from setAttribute, which is void.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Fix broken onget in tabScrolling property

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f703c5483fa0

Comment 3

[Philip Chee]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f703c5483fa0

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Why the return val; at all?

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f703c5483fa0

Comment 6

[Philip Chee]

(In reply to :Ms2ger from comment #4)
> Why the return val; at all?
I don't know. Firefox also does it this way:
http://hg.mozilla.org/mozilla-central/diff/ad8fc5dffc9c/toolkit/content/widgets/autocomplete.xml

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58e10a572314
Unnecessary return in tabScrolling property in XPFE autocomplete.xml NPOTB r=Neil DONTBUILD