1155075 - [Bluetooth2][File Transfer] It will not discovery devices automatically while shares file via Bluetooth.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[[e-mail], [e-mail]]

STR:
1. Turn Bluetooth on.
2. Go into Gallery app and pick a picture to share via Bluetooth.
3. See the list of devices in area.

Actual result:
Do not search devices automatically.

Expected result:
Should search devices automatically.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ian-liu:bluetooth/bug1155075_discovery_devices_automatically_while_share_files_via_bluetooth > mozilla-b2g:master

Comment 2

[[e-mail], [e-mail]]

Comment on attachment 8595825 [details] [review]
[gaia] ian-liu:bluetooth/bug1155075_discovery_devices_automatically_while_share_files_via_bluetooth > mozilla-b2g:master

Arthur,

Could you please help to review my pr for the bug fixing? The major changed are as following.

* To discovery device while 'device_picker_panel' init.
* Update the 'state', 'enabled' properties in 'BluetoothContext' module immediately while 'adapter.state' is changed.
* Create  '_syncWithSettingsKey' function to do this thing only.

I find out a race-condition issue is relative with updating BluetoothContext status. I update the 'state', 'enabled' properties after get()/set() mozSettings key. Sometimes, it causes we cannot discovery devices after Bluetooth is just turned off -> on. Because BluetoothContext will defect to do startDiscovery() by its state.

Since Bluetooth v2 code base is depends on the adapter state. I think it's better to update context state immediately. And no need to wait mozSettings sync completely. I will need your review here. Thanks.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8595825 [details] [review]
[gaia] ian-liu:bluetooth/bug1155075_discovery_devices_automatically_while_share_files_via_bluetooth > mozilla-b2g:master

The change makes sense because the setting is now considered as the user preference instead of the real hardware state. r=me, thanks!

Comment 4

[[e-mail], [e-mail]]

Thanks for Arthur's reviewing effort. Since patch is landed, we can close the issue now.

Gaia/master:  https://github.com/mozilla-b2g/gaia/commit/5d416244c0d9cbbb5823e872ac4b03addeb59bad