A portion of the reader view toolbar is still displayed when scrolling down on landscape

VERIFIED FIXED in Firefox 38

Status

()

VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: TeoVermesan, Assigned: Margaret)

Tracking

Trunk
Firefox 40
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox37 unaffected, firefox38 verified, firefox38.0.5 verified, firefox39 verified, firefox40 verified, fennec38+)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 8593232 [details]
Screenshot_2015-04-16-10-51-19.png

Tested with:
Device: Nexus 7 (Android 5.0)
Steps to reproduce:
1. Go to http://goo.gl/GdDxaP on landscape
2. Enter reader view by tapping the reader icon from URL Bar
3. Scroll down the article

Expected results:
- Reader view toolbar disappears

Actual results:
- A portion of the toolbar is still displayed
(Reporter)

Updated

4 years ago
status-firefox38: --- → affected
status-firefox39: --- → affected
Same behavior on Sony Xperia Z2 10" (4.4.4)
(Reporter)

Comment 2

4 years ago
2015-03-13 not affected
2015-03-14 affected
pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=42afc7ef5ccb&tochange=38154607d807

Regression from Bug 998031 - Reader Mode toolbar should scroll in and out instead of fading
(Assignee)

Updated

4 years ago
Assignee: nobody → margaret.leibovic
Blocks: 998031
(Assignee)

Comment 3

4 years ago
Created attachment 8593641 [details]
MozReview Request: bz://1155083/margaret

/r/7173 - Bug 1155083 - Properly hide reader view tablet on landscape tablets. r=bnicholson

Pull down this commit:

hg pull -r fb5340e8c10360d3f246955354935f8fdd49b007 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8593641 - Flags: review?(bnicholson)
(Assignee)

Updated

4 years ago
tracking-fennec: --- → 38+
(Assignee)

Comment 4

4 years ago
Comment on attachment 8593641 [details]
MozReview Request: bz://1155083/margaret

/r/7173 - Bug 1155083 - Properly hide reader view tablet on landscape tablets. r=bnicholson
/r/7175 - Bug 1154028 - Used scoped styles for reader view browser UI

Pull down these commits:

hg pull -r 1bb8d2facc875e061db2d58fcf6281842030a4fa https://reviewboard-hg.mozilla.org/gecko/
https://reviewboard.mozilla.org/r/7173/#review5987

Change looks OK to me, though I'm a bit confused by Review Board. It includes bug 1154028, though clicking it says it's discarded (but why does it still appear)?

Anyway, r=me assuming this lands only the top commit.
Comment on attachment 8593641 [details]
MozReview Request: bz://1155083/margaret

https://reviewboard.mozilla.org/r/7171/#review5991

Let's try this one more time...
Attachment #8593641 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 9

4 years ago
(In reply to Brian Nicholson (:bnicholson) from comment #5)
> https://reviewboard.mozilla.org/r/7173/#review5987
> 
> Change looks OK to me, though I'm a bit confused by Review Board. It
> includes bug 1154028, though clicking it says it's discarded (but why does
> it still appear)?

Yeah, this confuses me, too. I built the patch for that bug on top of this one, so I guess somehow they all get combined in that same head that got pushed to reviewboard?

In any case, I'm just landing this patch on its own.
(Assignee)

Comment 10

4 years ago
Comment on attachment 8593641 [details]
MozReview Request: bz://1155083/margaret

Approval Request Comment
[Feature/regressing bug #]: bug 998031

[User impact if declined]: Reader view toolbar won't be hidden properly on tablets in landscape.

[Describe test coverage new/current, TreeHerder]: Tested locally, just landed on fx-team.

[Risks and why]: Low-risk, very small CSS change.

[String/UUID change made/needed]: None.
Attachment #8593641 - Flags: approval-mozilla-beta?
Attachment #8593641 - Flags: approval-mozilla-aurora?
status-firefox37: --- → unaffected
https://hg.mozilla.org/mozilla-central/rev/d15ea1b053c4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment on attachment 8593641 [details]
MozReview Request: bz://1155083/margaret

Let's take it. Only to m-b as reader view is disabled in m-r.
Attachment #8593641 - Flags: approval-mozilla-beta?
Attachment #8593641 - Flags: approval-mozilla-beta+
Attachment #8593641 - Flags: approval-mozilla-aurora?
Attachment #8593641 - Flags: approval-mozilla-aurora+
(Reporter)

Comment 14

4 years ago
Reader view toolbar disappears when scrolling down an article on landscape, so:
Verified as fixed using:
Device: Nexus 7 (Android 5.0)
Build: Firefox for Android 40.0a1 (2015-04-23)
status-firefox40: fixed → verified
(Reporter)

Comment 17

4 years ago
Reader view toolbar disappears when scrolling down an article on landscape, so:
Verified as fixed using:
Device: Nexus 7 (Android 5.0)
Build: Firefox for Android 39.0a2 (2015-04-24)
status-firefox39: fixed → verified
(Reporter)

Comment 18

4 years ago
I am still able to reproduce this issue on 38 Beta 8 using Nexus 7 (Android 5.0)
(Assignee)

Comment 19

4 years ago
(In reply to Teodora Vermesan (:TeoVermesan) from comment #18)
> I am still able to reproduce this issue on 38 Beta 8 using Nexus 7 (Android
> 5.0)

When was that beta built? Does it have this changeset in it?
Flags: needinfo?(teodora.vermesan)

Comment 20

4 years ago
This beta was build in our morning ( your Sunday night ) from:
mobile commit: https://hg.mozilla.org/releases/mozilla-release/rev/8fc6195511e5 

I think this was not caught as the beta was build on release channel this time ( exceptional) 

The bug it on the beta channel only - https://hg.mozilla.org/releases/mozilla-beta/pushloghtml
Flags: needinfo?(teodora.vermesan) → needinfo?(margaret.leibovic)
status-firefox38: fixed → affected
This bug landed on mozilla-beta for 38.0.5, not mozilla-release for 38.0. There are no builds shipping off the mozilla-beta branch at this point unless you manually download it from the FTP.

Unfortunately, status-firefox38 has two different meanings at the moment depending on the specific branch a patch has landed on. Anyway, I think this bug not being fixed on 38 Beta 8 is entirely expected. And the status flag should probably be set back to fixed to reflect that.
Flags: needinfo?(sledru)
(Assignee)

Comment 22

4 years ago
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #21)
> This bug landed on mozilla-beta for 38.0.5, not mozilla-release for 38.0.
> There are no builds shipping off the mozilla-beta branch at this point
> unless you manually download it from the FTP.
> 
> Unfortunately, status-firefox38 has two different meanings at the moment
> depending on the specific branch a patch has landed on. Anyway, I think this
> bug not being fixed on 38 Beta 8 is entirely expected. And the status flag
> should probably be set back to fixed to reflect that.

So, what do we need to do if we want this fixed in Firefox 38? I just want to avoid shipping this regression to users.
Flags: needinfo?(margaret.leibovic) → needinfo?(ryanvm)
Convince Sylvestre to approve it for release. :) (I'm not release management, fwiw)
Flags: needinfo?(ryanvm)
(Assignee)

Comment 24

4 years ago
Comment on attachment 8593641 [details]
MozReview Request: bz://1155083/margaret

I didn't notice that this wasn't approved for 38. Reader view never has been and never will be disabled on Android, so I would like to avoid shipping this regression in 38.
Attachment #8593641 - Flags: approval-mozilla-release?
Comment on attachment 8593641 [details]
MozReview Request: bz://1155083/margaret

OK, I thought it was disabled
Should be in 38 beta 10.
Flags: needinfo?(sledru)
Attachment #8593641 - Flags: approval-mozilla-release? → approval-mozilla-release+
status-firefox38.0.5: --- → fixed
(Reporter)

Comment 28

4 years ago
Reader view toolbar disappears when scrolling down an article on landscape, so:
Verified as fixed using:
Device: Sony Xperia (Android 4.4)
Build: Firefox for Android 38 Beta 10 build 2
status-firefox38: fixed → verified
Verified as fixed on 38.0.5b4 on Nexus 7 (5.0.2)
Status: RESOLVED → VERIFIED
status-firefox38.0.5: fixed → verified
(Assignee)

Comment 30

3 years ago
Comment on attachment 8593641 [details]
MozReview Request: bz://1155083/margaret
Attachment #8593641 - Attachment is obsolete: true
Attachment #8620056 - Flags: review+
Attachment #8620057 - Flags: review+
(Assignee)

Comment 31

3 years ago
Created attachment 8620056 [details]
MozReview Request: Bug 1155083 - Properly hide reader view tablet on landscape tablets. r=bnicholson
(Assignee)

Comment 32

3 years ago
Created attachment 8620057 [details]
MozReview Request: Bug 1154028 - Used scoped styles for reader view browser UI
You need to log in before you can comment on or make changes to this bug.