1155112 - Disconnect the link clicker as the link generator leaves the conversation

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P3)

Description

[Romain Testard [:RT]]

As a link clicker, I want to be disconnected from the conversation when the link generator leaves the conversation so that I can't leave my camera running without noticing.

Acceptance criteria:
* When a link clicker is in a conversation, if the link generator leaves first, disconnect the link clicker automatically 
* When disconnected the link clicker is taken to the same page as if he had disconnected himself.

Comment 1

[Romain Testard [:RT]]

Sevaan, does this look right in terms of experience?

Comment 2

[Sevaan Franks [:sevaan]]

Thumbs up from me.

Comment 3

[Romain Testard [:RT]]

Shell, this feels like a high value/low effort bug. Maybe a good first bug?

Comment 4

[:shell escalante]

talked with gavin - not "good first bug" (easy for new, outside devs to take) P2?

Dan, can you get an estimate how hard this would be?  If it's a fairly simple bug - it would have a good impact to a confusing user scenario.

Comment 5

[Mark Banner (:standard8)]

I think we're missing part of the user story here.

RT:

- what should the UX be if the remote peer is disconnected due to a network issue or something?
- Do we want any message other than just "How was your conversation?" ?

Comment 6

[Romain Testard [:RT]]

(In reply to Mark Banner (:standard8) from comment #5)
> I think we're missing part of the user story here.
> 
> RT:
> 
> - what should the UX be if the remote peer is disconnected due to a network
> issue or something?
> - Do we want any message other than just "How was your conversation?" ?

Fair point, seems like we need to cover these scenarios more appropriately.
I added these as acceptance criteria to the bug.
Matej/Sevaan can you please help regarding the messaging to the user in these scenarios?

Comment 7

[Matej Novak [:matej]]

Here are some options for both:


* When a link clicker is in a conversation, if the link generator leaves first intentionally, disconnect the link clicker automatically and prompt him an informational message about what happened (MESSAGE 1 TBD) with an option to rejoin.

The other person left the conversation and you were automatically disconnected. [Rejoin] [Cancel]

The other person has left the conversation. Would you like to rejoin? [Yes] [No]

You have automatically left the conversation because the other person disconnected. [Rejoin] [Cancel]


* When a link clicker is in a conversation, if the link generator leaves first non intentionally (network error or other), disconnect the link clicker automatically and prompt him an informational message about what happened (MESSAGE 2 TBD) with an option to rejoin.

An error occurred and you were both disconnected from the conversation. [Rejoin] [Cancel]

The other person experienced an error and you were automatically disconnected. [Rejoin] [Cancel]

You have automatically left the conversation because the other person experienced an error. [Rejoin] [Cancel]

Comment 8

[Sevaan Franks [:sevaan]]

I like: 

> The other person has left the conversation. Would you like to rejoin? [Yes]
> [No]

> * When a link clicker is in a conversation, if the link generator leaves
> first non intentionally (network error or other), disconnect the link
> clicker automatically and prompt him an informational message about what
> happened (MESSAGE 2 TBD) with an option to rejoin.
> 
> An error occurred and you were both disconnected from the conversation.
> [Rejoin] [Cancel]
> 

I don't think we need a 'No' or 'Cancel' button though. Just a button that says "Rejoin" should suffice.

Comment 9

[Romain Testard [:RT]]

+1 to Sevaan's comments.
I amended the US to reflect this.

Comment 11

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.