stop using XULAPP_DEFINES for suite/debugQA/

RESOLVED FIXED in seamonkey2.37

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: froydnj, Assigned: iann_bugzilla)

Tracking

Trunk
seamonkey2.37
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.37 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

4 years ago
suite/debugQA/'s use of XULAPP_DEFINES is the sole reason that we have to have XULAPP_DEFINES for preprocessing DIST_FILES.  We should stop doing that.

I don't know whether this addon is still used or not...
(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #0)
> suite/debugQA/'s use of XULAPP_DEFINES is the sole reason that we have to
> have XULAPP_DEFINES for preprocessing DIST_FILES.  We should stop doing that.

I appreciate the thought, but suite/ is SeaMonkey, not Thunderbird. :-)
Component: Build Config → Build Config
Product: Thunderbird → SeaMonkey
Reporter

Comment 2

4 years ago
(In reply to Joshua Cranmer [:jcranmer] from comment #1)
> I appreciate the thought, but suite/ is SeaMonkey, not Thunderbird. :-)

My ignorance is revealed!  Thanks for moving that. :)

Comment 3

4 years ago
What should we use instead?
Assignee

Comment 4

4 years ago
As a quick note, DOM Inspector and Chatzilla also use XULAPP_DEFINES.
Assignee

Updated

4 years ago
Version: unspecified → Trunk
Assignee

Updated

4 years ago
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Assignee

Comment 5

4 years ago
An alternative could be to add something to suite/configure.in
Attachment #8598646 - Flags: review?(neil)
Attachment #8598646 - Flags: review?(neil) → review+

Comment 6

4 years ago
Comment on attachment 8598646 [details] [diff] [review]
Remove use of XULAPP_DEFINES from SM debugQA [Checked in: Comment 7]

a=me CLOSED TREE

Suggestion for future reference:

> +DEFINES['MOZ_APP_VERSION'] = CONFIG['MOZ_APP_VERSION']
> +DEFINES['MOZ_APP_MAXVERSION'] = CONFIG['MOZ_APP_MAXVERSION']

for var in ('MOZ_APP_NAME',
            'MOZ_APP_MAXVERSION'):
            DEFINES[var] = CONFIG[var]
Assignee

Comment 7

4 years ago
Comment on attachment 8598646 [details] [diff] [review]
Remove use of XULAPP_DEFINES from SM debugQA [Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/7ecc013abbd1
Attachment #8598646 - Attachment description: Remove use of XULAPP_DEFINES from SM debugQA → Remove use of XULAPP_DEFINES from SM debugQA [Checked in: Comment 7]
Assignee

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.37
You need to log in before you can comment on or make changes to this bug.