1155290 - stop using XULAPP_DEFINES for suite/debugQA/

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Nathan Froyd [:froydnj]]

suite/debugQA/'s use of XULAPP_DEFINES is the sole reason that we have to have XULAPP_DEFINES for preprocessing DIST_FILES.  We should stop doing that.

I don't know whether this addon is still used or not...

Comment 1

[Joshua Cranmer [:jcranmer]]

(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #0)
> suite/debugQA/'s use of XULAPP_DEFINES is the sole reason that we have to
> have XULAPP_DEFINES for preprocessing DIST_FILES.  We should stop doing that.

I appreciate the thought, but suite/ is SeaMonkey, not Thunderbird. :-)

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Joshua Cranmer [:jcranmer] from comment #1)
> I appreciate the thought, but suite/ is SeaMonkey, not Thunderbird. :-)

My ignorance is revealed!  Thanks for moving that. :)

Comment 3

[Philip Chee]

What should we use instead?

Comment 4

[Ian Neal]

As a quick note, DOM Inspector and Chatzilla also use XULAPP_DEFINES.

Comment 5

[Ian Neal]

Attachment: Remove use of XULAPP_DEFINES from SM debugQA [Checked in: Comment 7]

An alternative could be to add something to suite/configure.in

Comment 6

[Philip Chee]

Comment on attachment 8598646 [details] [diff] [review]
Remove use of XULAPP_DEFINES from SM debugQA [Checked in: Comment 7]

a=me CLOSED TREE

Suggestion for future reference:

> +DEFINES['MOZ_APP_VERSION'] = CONFIG['MOZ_APP_VERSION']
> +DEFINES['MOZ_APP_MAXVERSION'] = CONFIG['MOZ_APP_MAXVERSION']

for var in ('MOZ_APP_NAME',
            'MOZ_APP_MAXVERSION'):
            DEFINES[var] = CONFIG[var]

Comment 7

[Ian Neal]

Comment on attachment 8598646 [details] [diff] [review]
Remove use of XULAPP_DEFINES from SM debugQA [Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/7ecc013abbd1