1155304 - If I right-click the reading list "+" button (in URL bar), the page gets added to my reading list

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

+++ This bug was initially created as a clone of Bug #1148562 +++

STR:
 1. Visit a page that can be added to your reading list. e.g.:
     http://convolv.es/blog/2015/03/25/wifi-debug-fxos/
 2. Hover the URL bar so the "+" button shows up.
 3. Right-click the "+" button. (e.g. to see if it has a context-menu)

ACTUAL RESULTS: The page is added to my reading list, as if I'd left-clicked the button.

EXPECTED RESULTS: Nothing should happen (aside from perhaps a context-menu appearing).


For comparison, if I right-click the reload button, or the "site identity button" (both inside the URL bar), or if I right-click the "Home" button, I get the standard Firefox-toolbar context menu.

If I right-click blank space in the URL bar, I get the standard textfield context menu.

I'd expect that right-clicking the "+" button should have one of those two behaviors, for consistency.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Similar to bug 1148562.

Comment 2

[:Gijs (he/him)]

Comment on attachment 8593510 [details] [diff] [review]
Patch

Review of attachment 8593510 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8593510 [details] [diff] [review]
Patch

nit: use just "event", not "aEvent"

Maybe you can also update my ReaderParent.jsm change from https://hg.mozilla.org/releases/mozilla-beta/rev/4406ce9ace92 to match the new hip JS object function declaration style while you're at it?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2043c803e6b7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2043c803e6b7

Comment 6

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 40.0a1 (2015-04-24) using Ubuntu 14.04 (x64), Windows 7 (x64) and Mac OS X 10.9.5.