If I right-click the reading list "+" button (in URL bar), the page gets added to my reading list

VERIFIED FIXED in Firefox 40

Status

defect
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

(Blocks 1 bug)

Trunk
Firefox 40
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox40 verified)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1148562 +++

STR:
 1. Visit a page that can be added to your reading list. e.g.:
     http://convolv.es/blog/2015/03/25/wifi-debug-fxos/
 2. Hover the URL bar so the "+" button shows up.
 3. Right-click the "+" button. (e.g. to see if it has a context-menu)

ACTUAL RESULTS: The page is added to my reading list, as if I'd left-clicked the button.

EXPECTED RESULTS: Nothing should happen (aside from perhaps a context-menu appearing).


For comparison, if I right-click the reload button, or the "site identity button" (both inside the URL bar), or if I right-click the "Home" button, I get the standard Firefox-toolbar context menu.

If I right-click blank space in the URL bar, I get the standard textfield context menu.

I'd expect that right-clicking the "+" button should have one of those two behaviors, for consistency.
Posted patch PatchSplinter Review
Similar to bug 1148562.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8593510 - Flags: review?(gijskruitbosch+bugs)

Comment 2

4 years ago
Comment on attachment 8593510 [details] [diff] [review]
Patch

Review of attachment 8593510 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8593510 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8593510 [details] [diff] [review]
Patch

nit: use just "event", not "aEvent"

Maybe you can also update my ReaderParent.jsm change from https://hg.mozilla.org/releases/mozilla-beta/rev/4406ce9ace92 to match the new hip JS object function declaration style while you're at it?
Blocks: 1132074
Iteration: 40.1 - 13 Apr → 40.2 - 27 Apr
Flags: qe-verify?
Flags: firefox-backlog+
https://hg.mozilla.org/mozilla-central/rev/2043c803e6b7
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Flags: qe-verify? → qe-verify+
QA Contact: andrei.vaida
Verified fixed on Nightly 40.0a1 (2015-04-24) using Ubuntu 14.04 (x64), Windows 7 (x64) and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.