1155339 - Fix Windows build warnings

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

I had to debug a problem in windows recently and was disturbed at how many build warnings there are on that platform. This is an open meta-bug for pushing these lower.

Comment 1

[Daniel Holbert [:dholbert]]

Note that js/src/moz.build has FAIL_ON_WARNINGS = True, but that's inside of a GNU_CXX check -- so they're only fatal on GCC and clang right now.

Once this bug is fixed and MSVC warnings are gone, we can drop the GNU_CXX check to keep this directory warning-free on windows as well.

Comment 2

[Daniel Holbert [:dholbert]]

(per bug 1118149 comment 0, the GNU_CXX check is only there because the directory happened to be warning-free on GCC/clang at the time, but wasn't yet warning-free on MSVC.)

Comment 3

[Chris Peterson [:cpeterson]]

Bug 1230071 enabled warnings-as-errors in js/src for MSVC. Some MSVC warnings remain but are suppressed, in case anyone would like to fix them: bug 1229189 and bug 1229666.