Closed Bug 1155339 Opened 5 years ago Closed 4 years ago

Fix Windows build warnings

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox40 --- affected

People

(Reporter: terrence, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

I had to debug a problem in windows recently and was disturbed at how many build warnings there are on that platform. This is an open meta-bug for pushing these lower.
Note that js/src/moz.build has FAIL_ON_WARNINGS = True, but that's inside of a GNU_CXX check -- so they're only fatal on GCC and clang right now.

Once this bug is fixed and MSVC warnings are gone, we can drop the GNU_CXX check to keep this directory warning-free on windows as well.
(per bug 1118149 comment 0, the GNU_CXX check is only there because the directory happened to be warning-free on GCC/clang at the time, but wasn't yet warning-free on MSVC.)
Depends on: 1155838
Depends on: 1170673
Depends on: 1173908
Depends on: 1175636
Bug 1230071 enabled warnings-as-errors in js/src for MSVC. Some MSVC warnings remain but are suppressed, in case anyone would like to fix them: bug 1229189 and bug 1229666.
Status: NEW → RESOLVED
Closed: 4 years ago
Depends on: 1230071, 1229189, 1229666
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.