Closed Bug 1230071 Opened 5 years ago Closed 5 years ago

Enable warnings-as-errors in js shell and jsapi-tests

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Warnings-as-errors can't be enabled for all of js/src yet because of these MSVC warnings:

Bug 1229189 - C4146: unary minus operator applied to unsigned type

Bug 1229666 - C4273: inconsistent dll linkage (which may be fixed soon by Tooru's fdlibm patches in bug 933257)
Attachment #8695173 - Flags: review?(jwalden+bmo)
Comment on attachment 8695173 [details] [diff] [review]
enable-warnings-as-errors.patch

Review of attachment 8695173 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks -- it's doubtful I was going to get around to removing this stuff (as njn wanted, per IRC after I mentioned having that warning-fix handy) any time soon, given the mess that is the tree.  rs=me assuming (as always, but emphatically so here) that it passes try.  And if any oddball compilers exist that have additional warnings, we can fix 'em as needed in response to this.
Attachment #8695173 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/0ea205e98955
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Blocks: 1229189
Blocks: 1155339
No longer blocks: 1229189
Depends on: 1229666, 1229189
Blocks: 1135535
You need to log in before you can comment on or make changes to this bug.