Closed
Bug 1230071
Opened 9 years ago
Closed 9 years ago
Enable warnings-as-errors in js shell and jsapi-tests
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
|
2.54 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Warnings-as-errors can't be enabled for all of js/src yet because of these MSVC warnings:
Bug 1229189 - C4146: unary minus operator applied to unsigned type
Bug 1229666 - C4273: inconsistent dll linkage (which may be fixed soon by Tooru's fdlibm patches in bug 933257)
Attachment #8695173 -
Flags: review?(jwalden+bmo)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8695173 [details] [diff] [review]
enable-warnings-as-errors.patch
Review of attachment 8695173 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks -- it's doubtful I was going to get around to removing this stuff (as njn wanted, per IRC after I mentioned having that warning-fix handy) any time soon, given the mess that is the tree. rs=me assuming (as always, but emphatically so here) that it passes try. And if any oddball compilers exist that have additional warnings, we can fix 'em as needed in response to this.
Attachment #8695173 -
Flags: review?(jwalden+bmo) → review+
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
|
Assignee | |
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•