1155776 - move USE_EXTENSION_MANIFEST to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: move USE_EXTENSION_MANIFEST to moz.build

This patch could probably be improved if I understood what the check-jar-mn
tests in config/Makefile.in were testing and why they were trying to use
USE_EXTENSION_MANFEST.  Not completely usre about the documentation for the
moz.build variable...

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8594073 [details] [diff] [review]
move USE_EXTENSION_MANIFEST to moz.build

>diff --git a/python/mozbuild/mozbuild/backend/recursivemake.py b/python/mozbuild/mozbuild/backend/recursivemake.py
>index 99c3a9b..6d6a2d8 100644
>--- a/python/mozbuild/mozbuild/backend/recursivemake.py
>+++ b/python/mozbuild/mozbuild/backend/recursivemake.py
>@@ -109,16 +109,18 @@ MOZBUILD_VARIABLES = [
>     'SDK_LIBRARY',
>     'SHARED_LIBRARY_LIBS',
>     'SHARED_LIBRARY_NAME',
>     'SIMPLE_PROGRAMS',
>     'SONAME',
>     'STATIC_LIBRARY_NAME',
>     'TEST_DIRS',
>     'TOOL_DIRS',
>+    # XXX config/Makefile.in specifies this in a make invocation
>+    #'USE_EXTENSION_MANIFEST',

The config/Makefile.in invocation comes from bug 440675, and just appears to be a build system unit test to verify that the jar.mn processing works with USE_EXTENSION_MANIFEST=1. Moving config/tests/src-simple to a check in moz.build could probably be done as a separate bug.

>+    'USE_EXTENSION_MANIFEST': (bool, bool,
>+        """Whether to create chrome.manifest instead of jarfile.manifest for
>+        directories that define JAR_MANIFEST.
>+        """, None),

Might help to be a bit more explicit that you set it to True to create chrome.manifest, and that the default if unspecified is to create a jarfile.manifest.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eafb8c976ae2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eafb8c976ae2