Remove unused private browsing mask icons

RESOLVED FIXED in Firefox 40

Status

()

Firefox
Theme
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: James Lai, Mentored)

Tracking

Trunk
Firefox 40
Points:
---
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
These icons are unused and should be removed:

/browser/themes/linux/Privacy-32.png
/browser/themes/linux/Privacy-48.png
/browser/themes/linux/Privacy-64.png
/browser/themes/osx/Privacy-32.png
/browser/themes/osx/Privacy-48.png
/browser/themes/osx/Privacy-64.png
/browser/themes/windows/Privacy-32-XP.png
/browser/themes/windows/Privacy-32.png
/browser/themes/windows/Privacy-48-aero.png
/browser/themes/windows/Privacy-48.png
/browser/themes/windows/Privacy-64-aero.png
/browser/themes/windows/Privacy-64.png

Some of these images are referenced in /browser/themes/windows/jar.mn, those references need to be removed too.
Flags: firefox-backlog+
(Assignee)

Comment 1

3 years ago
Hi Dao,

I am interested in and going to work on this bug.
(Assignee)

Comment 2

3 years ago
Created attachment 8594440 [details] [diff] [review]
Bug 1155956 patch 01
(Assignee)

Comment 3

3 years ago
Hi Dao,

Just attached the patch. Appreciate if you may help check?
(Reporter)

Comment 4

3 years ago
Comment on attachment 8594440 [details] [diff] [review]
Bug 1155956 patch 01

Nice! Looks perfect.
Attachment #8594440 - Flags: review+
(Reporter)

Updated

3 years ago
Assignee: nobody → jlaiosd
(Reporter)

Comment 6

3 years ago
If you're interested in fixing another very similar bug, there's bug 1150800. Seems like the person who started working on this got stuck and gave up.
https://hg.mozilla.org/mozilla-central/rev/284297151baa
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40

Updated

3 years ago
Iteration: --- → 40.2 - 27 Apr
Flags: qe-verify?
(Reporter)

Updated

3 years ago
Flags: qe-verify? → qe-verify-
(Assignee)

Comment 8

3 years ago
(In reply to Dão Gottwald [:dao] from comment #6)
> If you're interested in fixing another very similar bug, there's bug
> 1150800. Seems like the person who started working on this got stuck and
> gave up.

Thanks and yes I would love to work on other bug fixes.
You need to log in before you can comment on or make changes to this bug.