Closed Bug 1155956 Opened 9 years ago Closed 9 years ago

Remove unused private browsing mask icons

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Iteration:
40.2 - 27 Apr
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: dao, Assigned: jlaiosd, Mentored)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Bug 1155956 patch 01
6.73 KB, patch
dao
: review+
Details | Diff | Splinter Review 
These icons are unused and should be removed:

/browser/themes/linux/Privacy-32.png
/browser/themes/linux/Privacy-48.png
/browser/themes/linux/Privacy-64.png
/browser/themes/osx/Privacy-32.png
/browser/themes/osx/Privacy-48.png
/browser/themes/osx/Privacy-64.png
/browser/themes/windows/Privacy-32-XP.png
/browser/themes/windows/Privacy-32.png
/browser/themes/windows/Privacy-48-aero.png
/browser/themes/windows/Privacy-48.png
/browser/themes/windows/Privacy-64-aero.png
/browser/themes/windows/Privacy-64.png

Some of these images are referenced in /browser/themes/windows/jar.mn, those references need to be removed too.
Flags: firefox-backlog+
Hi Dao,

I am interested in and going to work on this bug.

    
    

    
  
Hi Dao,

Just attached the patch. Appreciate if you may help check?

    
    

    
  
Comment on attachment 8594440 [details] [diff] [review]
Bug 1155956 patch 01

Nice! Looks perfect.

        Attachment #8594440 -
        Flags: review+

    
  
Assignee: nobody → jlaiosd

    
    

    
  
If you're interested in fixing another very similar bug, there's bug 1150800. Seems like the person who started working on this got stuck and gave up.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/284297151baa
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox40:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Iteration: --- → 40.2 - 27 Apr
Flags: qe-verify?

    
  
Flags: qe-verify? → qe-verify-

    
    

    
  
(In reply to Dão Gottwald [:dao] from comment #6)
> If you're interested in fixing another very similar bug, there's bug
> 1150800. Seems like the person who started working on this got stuck and
> gave up.

Thanks and yes I would love to work on other bug fixes.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: