Closed Bug 1156088 Opened 9 years ago Closed 9 years ago

Doorhangers display useless "Learn more..." link when using the Modern theme

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Version:
SeaMonkey 2.27 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.34 affected, seamonkey2.35 affected, seamonkey2.36 fixed, seamonkey2.37 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.37
Tracking Flags:
Tracking Status
seamonkey2.34 --- affected
seamonkey2.35 --- affected
seamonkey2.36 --- fixed
seamonkey2.37 --- fixed

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Proposed patch
528 bytes, patch
philip.chee
: review+
iannbugzilla
: approval-comm-aurora+
iannbugzilla
: approval-comm-beta+
philip.chee
: approval-comm-release-
Details | Diff | Splinter Review 
When bug 967349 added the "Learn more..." link to doorhangers they had the bright idea of controlling the visibility of the link in skin rather than content.

Not only does this mean that the rule gets triplicated in Firefox but it also means that we need to port it to Modern.
Attached patch Proposed patch — — Splinter Review 
The extra margin doesn't seem to buy us anything so I ignored it.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8594507 - Flags: review?(philip.chee)
Attachment #8594507 - Flags: review?(philip.chee) → review+
Pushed comm-central changeset b5f6484178b7.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-seamonkey2.37: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.37
Comment on attachment 8594507 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 967349
User impact if declined: Useless UI
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #8594507 - Flags: approval-comm-beta?
Attachment #8594507 - Flags: approval-comm-aurora?
Attachment #8594507 - Flags: approval-comm-beta?
Attachment #8594507 - Flags: approval-comm-beta+
Attachment #8594507 - Flags: approval-comm-aurora?
Attachment #8594507 - Flags: approval-comm-aurora+
Comment on attachment 8594507 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 967349
User impact if declined: Useless UI
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #8594507 - Flags: approval-comm-release?
Blocks: SM2.35-Uplift
Attachment #8594507 - Flags: approval-comm-release? → approval-comm-release-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: